Repository navigation
CFG: Avoid bad join in {begin,end}AbruptCompletion - #22989
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
hvitved
changed the title
{begin,emdAbruptCompletion
hvitved
changed the title
{begin,emdAbruptCompletion{begin,end}AbruptCompletion
hvitved
marked this pull request as ready for review
November 3, 2026 08:38
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the shared control-flow abrupt-completion changes.
No open issues 🎉
What changed in this PR
Updates shared control-flow graph handling to avoid inefficient joins in abrupt-completion processing, addressing the issue encountered with Rust.
Changes:
- Constructs abrupt completions directly from successor types and optional labels in
beginAbruptCompletion. - Applies the same approach to loop break and continue handling in
endAbruptCompletion, joining both labeled-completion columns together.
| File | Description |
|---|---|
shared/controlflow/codeql/controlflow/ControlFlowGraph.qll |
Replaces separate successor-type and label lookups with direct abrupt-completion constructor matches. |
Review effort: Balanced (auto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for Rust, where we otherwise get a bad join because
TLabeledAbruptCompletionis not joined on both columns simultaneously.