Skip to content

Dataflow: Expose stage 1's fwdFlow #21631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MathiasVP merged 2 commits into from
Apr 7, 2026
+7 −1
Merged

Dataflow: Expose stage 1's fwdFlow #21631

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d8b782
Shared: Also expose dataflow stage 1's forward flow predicate.
MathiasVP Apr 2, 2026
e06294b
Shared: Respond to review comments.
MathiasVP Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion shared/dataflow/codeql/dataflow/internal/DataFlowImplStage1.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ module MakeImplStage1<LocationSig Location, InputSig<Location> Lang> {
bindingset[p, kind]
predicate parameterFlowThroughAllowed(ParamNd p, ReturnKindExt kind);

predicate fwdFlow(Nd node);

// begin StageSig
class Ap;

Expand Down Expand Up @@ -634,7 +636,7 @@ module MakeImplStage1<LocationSig Location, InputSig<Location> Lang> {
)
}

private predicate fwdFlow(NodeEx node) { fwdFlow(node, _) }
predicate fwdFlow(NodeEx node) { fwdFlow(node, _) }

pragma[nomagic]
private predicate fwdFlowReadSet(ContentSet c, NodeEx node, Cc cc) {
Expand Down Expand Up @@ -1291,6 +1293,8 @@ module MakeImplStage1<LocationSig Location, InputSig<Location> Lang> {
import Stage1
import Stage1Common

predicate fwdFlow(Nd node) { Stage1::fwdFlow(node) }

predicate revFlow(NodeEx node, Ap ap) { Stage1::revFlow(node) and exists(ap) }

predicate toNormalSinkNode = toNormalSinkNodeEx/1;
Expand Down Expand Up @@ -1395,6 +1399,8 @@ module MakeImplStage1<LocationSig Location, InputSig<Location> Lang> {

import Stage1Common

predicate fwdFlow(Nd node) { Stage1::fwdFlow(node.getNodeEx()) }

predicate revFlow(Nd node) { Stage1::revFlow(node.getNodeEx()) }

predicate revFlow(Nd node, Ap ap) { Stage1::revFlow(node.getNodeEx()) and exists(ap) }
Expand Down
Loading