[ukorvl]

Pull Request Checklist

• I have read and followed the CONTRIBUTING.md guidelines.
• I have read and followed the Guidance for submissions involving paid services.
• My contribution adds a new instruction, prompt, agent, skill, workflow, or canvas extension file in the correct directory.
• The file follows the required naming convention.
• The content is clearly structured and follows the example format.
• I have tested my instructions, prompt, agent, skill, workflow, or canvas extension with GitHub Copilot.
• I have run npm start and verified that README.md is up to date.
• I am targeting the main branch for this pull request.

---

Description

Adds skills/lightweight-charts-react-components/ and its generated entry in docs/README.skills.md.

Financial-chart integrations have a few wrapper-specific failure modes: reactive data={[latestBar]} discards history, fitting on every tick resets the viewport, WebSocket callbacks can outlive their series, and wrapper refs expose .api() only after initialization. The skill supplies concrete TypeScript recipes for those cases, history pagination, indicator panes, legends/tooltips, visual markers, synchronized charts, primitives, and numeric axes. It complements general React/TypeScript guidance with chart data ownership and lifecycle contracts.

The bundle retains the nine source references and MIT license. This is a native skill contribution; no external plugin catalog entry is added.

---

Type of Contribution

• New instruction file.
• New prompt file.
• New agent file.
• New plugin.
• New skill file.
• New agentic workflow.
• New canvas extension.
• Update to existing instruction, prompt, agent, plugin, skill, workflow, or canvas extension.
• Other (please specify):

---

Additional Notes

I maintain the original library and skill. Codex prepared this contribution on my behalf. The source is pinned at 0368191127568e48aef6f7bda2ff3900e8e24756; the catalog copy adds attribution and operational boundaries. Two references now contain local review corrections: runtime timestamp validation and version-specific reactive-update guidance in market-data-and-live-updates.md, plus the primitive callback lifecycle in session-overlays-and-primitives.md. The other seven reference files and MIT notice are unchanged. No TradingView endorsement is implied.

Validation:

• npm ci --ignore-scripts, npm run skill:validate, npm run plugin:validate, npm start (the documented build), and git diff --check pass. The generated docs contain exactly one new skill row; root README and marketplace are unchanged. Three existing external-plugin license warnings are unrelated to this addition.
• Ran the required bash eng/fix-line-endings.sh with a temporary, self-tested GNU-to-BSD sed compatibility shim on macOS. The original invocation uses GNU sed -i syntax and reports errors on BSD sed. The compatible run passes; new files use LF. No script or tool shim is included in the PR.
• Actual GitHub Copilot CLI 1.0.105 host test: with this skill in a disposable project's .github/skills/, asked it to diagnose history loss from [latestBar] and zoom resets from live fit dependencies, then produce a complete React-owned live-candle component. Copilot loaded the skill and live-updates reference, explained both causes, and generated complete-history tail updates, cleanup, explicit chart height/autoSize, native types, and a stable fit trigger.
• The actual generated component passes strict tsc --noEmit using TypeScript 5.9.3, React/React DOM 19.2.6, Lightweight Charts 5.2.1, and wrapper 2.6.1. Repository validation ran on Node 24.4.0 and npm 11.19.1.
• npx @microsoft/vally-cli lint skills/lightweight-charts-react-components --verbose passes both spec-compliance and valid-refs checks.
• Review follow-up: ran the adapter extracted directly from the Markdown recipe. Reproduced the old epoch-zero coercion for null, empty-string and false timestamps; the fixed adapter rejects 16 malformed timestamp cases through both normalizeCandle and normalizeHistory. Valid numeric timestamps (including zero), numeric OHLC strings, sorting and same-time reconciliation pass. The edited adapter also passes strict TypeScript checking.
• Verified the reactive-update limitation against the installed wrapper 2.6.1 and Lightweight Charts 5.2.1 source, including series.data() object reconstruction and the wrapper's reference comparison. Verified the native primitive's updateAllViews() dispatch. These are source inspections, not new browser performance tests.
• Reran skill/plugin validation, build, line-ending normalization, Vally's two static checks, and git diff --check after the review fixes; all pass.
• Browser interaction, live WebSocket/provider behavior, and every recipe combination were not tested in this session. The host test and typecheck are not claims of full runtime coverage. The earlier Copilot generation session was not rerun for these focused corrections.

The chart library and skill are open-source. No account is required for synthetic local data. Real feeds use the application's separately authorized adapter; the skill does not place orders, deploy, or sign up for a service.

---

By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

[github-actions]

🔒 PR Risk Scan Results

Scanned 11 changed file(s).

Severity	Count
🔴 High	0
🟠 Medium	0
ℹ️ Info	0

✅ No matching risk patterns were detected in changed files.

This is an automated soft-gate report. Findings indicate review targets and do not block merge by themselves.

[github-actions]

🟡 Contributor Reputation Check: MEDIUM risk

Check	Risk
Profile	MEDIUM
Credential audit	NONE

Maintainers: please review this contributor before merging.
See the workflow run for full details.
Automated check powered by AGT.

[github-actions]

🚦 Submission status: 👀 Ready for review

Risk tier: merge-risk:medium — New or substantially changed resource without privileged execution
Required to merge: passing submission-gate checks plus 1 approval from reviewers with write access.

Why this tier

• Adds 11 file(s), e.g. skills/lightweight-charts-react-components/LICENSE
• Changes 2396 lines (low-risk limit is 40)

Automated checks

Check	Status	Details
Line endings	✅ Passed	Passed · logs
Spelling	✅ Passed	Passed · logs
Generated README consistency	✅ Passed	Passed · logs
Skill validation	✅ Passed	Passed · logs
Skill lint (vally)	✅ Passed	Passed · logs
Risk scan	✅ Passed	Passed · logs
Contributor reputation	✅ Passed	Passed · logs
Duplicate resource scan	✅ Passed	Passed · logs
PR quality signal	⏭️ Skipped	Skipped by its workflow · logs

Review

• Approvals: 0/1
• Assigned reviewer: not assigned yet — comment /request-review to ask for one
• Review target date: not set
• Still needed: 1 more approval(s)
• No staffed reviewer pool owns these files yet; any reviewer with write access counts as the domain reviewer.

Commands

Command	Who	What it does
/rerun-checks	PR author, maintainers	Re-runs failed or incomplete checks and re-evaluates this gate
/request-review	PR author, maintainers	Asks the review rotation to assign a reviewer (adds needs-reviewer)

_{Updated for 8ea38ad · gate run · This comment is maintained automatically — see submission gate docs.}

[github-actions]

🔍 Vally Lint Results

✅ All checks passed

Scope	Checked
Skills	1
Agents	0
Total	1

Severity	Count
❌ Errors	0
⚠️ Warnings	0
ℹ️ Advisories	0

Summary

Level	Finding
ℹ️	✅ lightweight-charts-react-components (2/2 checks passed)
ℹ️	✓ [spec-compliance] All 1 skill(s) are spec-compliant.
ℹ️	✓ spec-compliance: All spec checks passed.
ℹ️	✓ [valid-refs] All file references across 1 skill(s) are valid.
ℹ️	✓ valid-refs: All file references resolve to existing files within the skill directory.
ℹ️	1 skill(s) linted, 1 passed

Full linter output

### Linting skills/lightweight-charts-react-components
✅ lightweight-charts-react-components (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.

1 skill(s) linted, 1 passed

[Copilot]

🟡 Changes recommended

Timestamp normalization lacks a runtime type check, allowing null, empty-string, or false values to produce invalid epoch-zero candles instead of being rejected.

3 open issues

• Reject nonnumeric timestamps before converting to seconds · New
• Document reconstructed series data and incremental update limits · New
• Recalculate primitive view coordinates in updateAllViews() · New

What changed in this PR

Adds a specialized skill to the Copilot catalog for building React financial charts, with guidance on data ownership, API readiness, and preserving the viewport during updates.

Changes:

• Adds skill metadata, setup guidance, compatibility details, and operational boundaries.
• Bundles nine reference recipes with upstream attribution and an MIT license.
• Registers the skill in the generated skills catalog.

File	Description
skills/​lightweight-charts-react-components/​SKILL.md	Defines the skill and routes users to relevant recipes.
skills/​lightweight-charts-react-components/​references/​trade-markers-and-price-levels.md	Covers execution markers and editable price levels.
skills/​lightweight-charts-react-components/​references/​synchronized-charts.md	Explains range and crosshair synchronization.
skills/​lightweight-charts-react-components/​references/​session-overlays-and-primitives.md	Provides session shading and custom primitive guidance.
skills/​lightweight-charts-react-components/​references/​price-volume-and-indicators.md	Demonstrates indicator panes and independent scales.
skills/​lightweight-charts-react-components/​references/​performance-comparison.md	Implements fixed-baseline asset return comparisons.
skills/​lightweight-charts-react-components/​references/​numeric-axes-and-chart-types.md	Covers strike, maturity, and custom horizontal axes.
skills/​lightweight-charts-react-components/​references/​market-data-and-live-updates.md	Provides feed normalization and live-update recipes.
skills/​lightweight-charts-react-components/​references/​hover-legends-and-tooltips.md	Adds live OHLC legends and positioned tooltips.
skills/​lightweight-charts-react-components/​references/​history-and-range-selection.md	Covers history pagination and dataset replacement.
skills/​lightweight-charts-react-components/​LICENSE	Includes the upstream MIT license text.
docs/​README.skills.md	Adds the skill’s installation link and resource listing.

_{Review effort: Balanced (auto)}

[ukorvl]

@copilot Fix the code for all comments in this review thread.

When a review comment includes a suggested change, apply the suggestion exactly.

Do not make changes beyond what is described in the linked review thread.

[Copilot]

🟢 Approval recommended

No active review issues block the charting skill addition and its bundled references.

No open issues 🎉

3 resolved since last review

• Reject nonnumeric timestamps before converting to seconds
• Recalculate primitive view coordinates in updateAllViews()
• Document reconstructed series data and incremental update limits

_{Review effort: Balanced (auto)}