Skip to content

Add falsifiable code review findings instructions 🤖🤖🤖 - #6149

Open
itscloud0 wants to merge 1 commit into
github:mainfrom
itscloud0:add-falsifiable-code-review-instructions
Open

itscloud0 wants to merge 1 commit into
github:mainfrom
itscloud0:add-falsifiable-code-review-instructions

Conversation

@itscloud0

@itscloud0 itscloud0 commented Oct 31, 2026 •

Copy link
Copy Markdown

Adds instructions/code-review-falsifiable-findings.instructions.md and the regenerated docs/README.instructions.md row (npm start).

What it does: steers Copilot code review away from speculative comments. Each finding must give the file and line, a concrete triggering input, the expected result, the predicted result, and the smallest test that fails today. Items without a trigger are labeled question; untraced paths are labeled not traced; the review ends with the three highest-risk findings, what was not reviewed, and one decision.

Why it is not a duplicate of code-review-generic: that file covers what to look for (priorities, security, quality). This one constrains the shape of each finding so a human can confirm or reject it with one test, which matters most for AI-generated patches that pass the obvious case and fail at a boundary.

Usage notes: uses excludeAgent: 'cloud-agent' so it applies to code review only (value checked against the current GitHub custom-instructions docs). Treats the PR description as the change's intent.

Testing / disclosure: the frontmatter and format follow the docs and the README was regenerated with npm start. I have not run it against a live Copilot code review session. The same rules are published as an MIT repo at https://github.com/itscloud0/ai-code-review-prompt, which I maintain. Prepared by an AI coding agent on my behalf.

@itscloud0
itscloud0 requested review from a team as code owners October 31, 2026 22:53
@github-actions

Copy link
Copy Markdown
Contributor

🔒 PR Risk Scan Results

Scanned 1 changed file(s).

Severity Count
🔴 High 0
🟠 Medium 0
ℹ️ Info 0

✅ No matching risk patterns were detected in changed files.

This is an automated soft-gate report. Findings indicate review targets and do not block merge by themselves.

@github-actions github-actions Bot added instructions PR touches instructions new-submission PR adds at least one new contribution labels Oct 31, 2026
@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

🟡 Contributor Reputation Check: MEDIUM risk

Check Risk
Profile MEDIUM
Credential audit NONE

Maintainers: please review this contributor before merging.
See the workflow run for full details.
Automated check powered by AGT.

@github-actions github-actions Bot added needs-review:MEDIUM Contributor reputation check flagged MEDIUM risk merge-risk:medium ready-for-review Submission passed intake validation and is ready for maintainer review labels Oct 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚦 Submission status: 👀 Ready for review

Risk tier: merge-risk:medium — New or substantially changed resource without privileged execution
Required to merge: passing submission-gate checks plus 1 approval from reviewers with write access.

Why this tier
  • Adds 1 file(s), e.g. instructions/code-review-falsifiable-findings.instructions.md
  • Changes 70 lines (low-risk limit is 40)

Automated checks

Check Status Details
Line endings ✅ Passed Passed · logs
Spelling ✅ Passed Passed · logs
Generated README consistency ✅ Passed Passed · logs
Risk scan ✅ Passed Passed · logs
Contributor reputation ✅ Passed Passed · logs
Duplicate resource scan ✅ Passed Passed · logs
PR quality signal ⏭️ Skipped Skipped by its workflow · logs

Review

  • Approvals: 0/1
  • Assigned reviewer: not assigned yet — comment /request-review to ask for one
  • Review target date: not set
  • Still needed: 1 more approval(s)
  • No staffed reviewer pool owns these files yet; any reviewer with write access counts as the domain reviewer.

Commands

Command Who What it does
/rerun-checks PR author, maintainers Re-runs failed or incomplete checks and re-evaluates this gate
/request-review PR author, maintainers Asks the review rotation to assign a reviewer (adds needs-reviewer)

Updated for e4c9b4b · gate run · This comment is maintained automatically — see submission gate docs.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

instructions PR touches instructions merge-risk:medium needs-review:MEDIUM Contributor reputation check flagged MEDIUM risk new-submission PR adds at least one new contribution ready-for-review Submission passed intake validation and is ready for maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant