Repository navigation
Add skill distribution audit with discovery reconciliation - #5991
findscripter wants to merge 2 commits into
Conversation
🔒 PR Risk Scan ResultsScanned 4 changed file(s).
|
🚦 Submission status: 💬 Review in progressRisk tier: Why this tier
Automated checks
Review
Commands
Updated for |
|
🟡 Contributor Reputation Check: MEDIUM risk
Maintainers: please review this contributor before merging. |
🔍 Vally Lint Results✅ All checks passed
Summary
Full linter output |
aaronpowell
left a comment
There was a problem hiding this comment.
I'm struggling to understand how this uplifts Copilot's capabilities.
Copilot is already very capable of discovering agent capabilities (such as skill, mcp servers, etc.) since the tooling will load those.
|
Thanks @aaronpowell, that's a fair point. I've narrowed the contribution in 11a11ef to a skill distribution audit for collection maintainers. The concrete motivating case was a collection with 1,093 intended active skills where the installer listed 1,076 entries: 38 active skills were missing, while 20 archived skills and one template were included. Comparing totals hid the omissions and leaks. The historical receipt records the source revision, consumer version, and before/after results. The updated skill reconciles the intended public source set, the applicable manifest, and actual discovery output, with a deterministic helper for missing, unexpected, and duplicate identities. I removed the generic inventory, onboarding, and extension-selection guidance. Seven helper tests pass, along with validation, lint, and build checks. The intended value is a repeatable release-validation workflow. Discovery coverage is explicitly separate from runtime loading or successful execution, and I haven't claimed a measured improvement over baseline Copilot. |
Problem and resulting behavior
A skill collection can pass its own index/build checks while a consumer omits intended skills or exposes archived and template entries. Comparing total counts can hide both kinds of error.
This adds
skill-distribution-auditfor maintainers investigating release/discovery mismatches. It reconciles the intended public source set, the applicable distribution manifest, and actual consumer discovery output at a specified revision and consumer version.What this provides
Concrete motivating case
In a collection I maintain,
skills@1.7.4discovered 1,076 entries against an intended active set of 1,093: 38 active skills were missing, while 20 archived skills and one template were included. The net difference of 17 hid the two directions of failure. Fixes addressed standard YAML compatibility and that consumer version's internal-entry filtering; the recorded follow-up discovery matched 1,093 unique intended identities.These are distribution observations, not a benchmark showing an improvement over baseline Copilot. This update replays existing captured discovery data; it does not claim a fresh installer run. Consumer-specific fields are not presented as universal Copilot requirements.
Validation
node --test skills/skill-distribution-audit/scripts/compare-discovery.test.mjs: 7 tests passed, including equal-count mismatches, duplicate identities, input preservation, error exit codes, and linked installation directories.npm run skill:validate: all 449 skills passed.npm run build, skill-creator validation, required line-ending normalization, andgit diff --checkpassed.Affiliation: None