Skip to content

Fix Agent Radar particle paths after graph rebuilds 🤖🤖🤖 - #5973

Open
tkjaer wants to merge 2 commits into
github:mainfrom
tkjaer:tkjaer-agent-radar-particle-fix
Open

tkjaer wants to merge 2 commits into
github:mainfrom
tkjaer:tkjaer-agent-radar-particle-fix

Conversation

@tkjaer

@tkjaer tkjaer commented Oct 29, 2026

Copy link
Copy Markdown

Pull Request Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have read and followed the Guidance for submissions involving paid services.
  • My contribution adds a new instruction, prompt, agent, skill, workflow, or canvas extension file in the correct directory.
  • The file follows the required naming convention.
  • The content is clearly structured and follows the example format.
  • I have tested my instructions, prompt, agent, skill, workflow, or canvas extension with GitHub Copilot.
  • I have run npm start and verified that README.md is up to date.
  • I am targeting the main branch for this pull request.

Description

Keeps in-flight Agent Radar particles on the correct path after the graph rebuilds. Particles now move to the rebuilt link with the same endpoints, while particles for removed links are dropped.

This upstreams awlx/agent-radar-app#3. See github/awesome-copilot#5118 for repository context.


Type of Contribution

  • New instruction file.
  • New prompt file.
  • New agent file.
  • New plugin.
  • New skill file.
  • New agentic workflow.
  • New canvas extension.
  • Update to existing instruction, prompt, agent, plugin, skill, workflow, or canvas extension.
  • Other (please specify):

Additional Notes

N/A.


By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

Remap in-flight particles to rebuilt link objects and drop particles whose endpoints disappear.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@tkjaer
tkjaer requested a review from a team as a code owner October 29, 2026 15:07
Copilot AI auto review requested due to automatic review settings October 29, 2026 15:07
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

🚦 Submission status: 🛠️ Requires submitter fixes

Risk tier: merge-risk:low — Documentation, metadata, generated output, or a small update to an existing resource
Required to merge: passing submission-gate checks plus 1 approval from reviewers with write access.

Why this tier
  • Small update (32 changed lines) to existing resources with no added or removed files

Automated checks

Check Status Details
Line endings ✅ Passed Passed · logs
Spelling ✅ Passed Passed · logs
Generated README consistency ✅ Passed Passed · logs
Plugin and extension validation ✅ Passed Passed · logs
Canvas extension validation ✅ Passed Passed · logs
Plugin structure ✅ Passed Passed · logs
Risk scan ✅ Passed Passed · logs
Contributor reputation ✅ Passed Passed · logs
Duplicate resource scan ✅ Passed Passed · logs
PR quality signal ⏭️ Skipped Skipped by its workflow · logs
Canvas/plugin smoke test ✅ Passed Passed · logs

Action needed

  • Address the changes requested by aaronpowell, then push an update.

Review

  • Approvals: 0/1
  • Assigned reviewer: not assigned yet — comment /request-review to ask for one
  • Review target date: not set
  • Still needed: 1 more approval(s); resolution of changes requested by aaronpowell
  • No staffed reviewer pool owns these files yet; any reviewer with write access counts as the resource owner.

Commands

Command Who What it does
/rerun-checks PR author, maintainers Re-runs failed or incomplete checks and re-evaluates this gate
/request-review PR author, maintainers Asks the review rotation to assign a reviewer (adds needs-reviewer)

Updated for df84c1c · gate run · This comment is maintained automatically — see submission gate docs.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Canvas smoke test

✅ Passed · 0 error(s), 2 warning(s)

Check Result
Syntax, imports, file safety ✅
Preview image (≥ 400×160 PNG) ✅
Plugin manifests ✅
Materialize ✅
Install (Copilot CLI) ✅

Plugin agent-radar v1.0.1

Field Value
Description See a live map of the Copilot agents on your computer, their sub-agents, their commands, and where their data goes.
Author Annika Wickert — https://github.com/awlx
License MIT
Keywords agents, canvas, copilot-extension, data-flow, mcp, observability, subagents, token-usage
Extensions agent-radar
Materialize ✅
Install ✅
Changed plugin files
  • plugins/agent-radar/plugin.json

Extension agent-radar

agent-radar preview

Field Value
Registered by agent-radar
Package —
Preview 1600×1000, 443.1 KB
Modules 4 (2 reachable from extension.mjs)
Files 9

Permissions and capabilities (static analysis of modules reachable from extension.mjs)

  • File system access (node:fs)
  • Network sockets / local server (node:http, node:net, ...)
  • Host information (node:os)
  • Reads environment variables (process.env)

Warnings

  • collector.test.mjs: import "node:test" is not a Node.js builtin, host-provided package, or declared dependency (module is not reachable from extension.mjs)
  • graph.test.mjs: import "node:test" is not a Node.js builtin, host-provided package, or declared dependency (module is not reachable from extension.mjs)
Changed extension files
  • extensions/agent-radar/graph.test.mjs
  • extensions/agent-radar/ui.html

Static checks compile modules without executing them. Minimum preview size is configurable with CANVAS_PREVIEW_MIN_WIDTH/CANVAS_PREVIEW_MIN_HEIGHT. Workflow run

@github-actions github-actions Bot added ready-for-review Submission passed intake validation and is ready for maintainer review and removed awaiting-automation labels Oct 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the particle-link remapping change.

No open issues 🎉

What changed in this PR

Fixes particle animation in the existing Agent Radar canvas extension so in-flight particles follow the correct paths after graph rebuilds.

Changes:

  • Reassigns particles to rebuilt links with matching endpoints and drops particles whose links were removed.
  • Adds regression coverage for particle behavior when idle visibility and sub-agent state change.
File Description
extensions/​agent-radar/​ui.html Remaps in-flight particles to current links after each graph rebuild.
extensions/​agent-radar/​graph.test.mjs Exposes particle state in the test harness and verifies link reassignment and removal.

Review effort: Balanced (auto)

@aaronpowell aaronpowell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires a version bump to the plugin otherwise clients aren't notified of the change and thus won't receive it.

@github-actions github-actions Bot added requires-submitter-fixes Submission has quality-gate findings that submitter must fix before maintainer review and removed ready-for-review Submission passed intake validation and is ready for maintainer review labels Nov 2, 2026
Publish the particle-path fix as version 1.0.1 so clients detect the update.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@tkjaer
tkjaer requested a review from a team as a code owner November 2, 2026 07:03
Copilot AI auto review requested due to automatic review settings November 2, 2026 07:03
@tkjaer

tkjaer commented Nov 2, 2026

Copy link
Copy Markdown
Author

Bumped the Agent Radar plugin version from 1.0.0 to 1.0.1 in df84c1c so clients detect the particle-path update.

@github-actions github-actions Bot added the plugin PR touches plugins label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

🔒 PR Risk Scan Results

Scanned 4 changed file(s).

Severity Count
🔴 High 0
🟠 Medium 0
ℹ️ Info 0

✅ No matching risk patterns were detected in changed files.

This is an automated soft-gate report. Findings indicate review targets and do not block merge by themselves.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the particle-rebinding change.

No open issues 🎉

Review effort: Balanced (auto)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

canvas-extension PR touches canvas extensions merge-risk:low plugin PR touches plugins requires-submitter-fixes Submission has quality-gate findings that submitter must fix before maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants