[GHSA-5grx-v727-qmq6] github.com/1Panel-dev/1Panel: patched version 1.10.12-tls does not exist on the registry; the fix is in 1.10.12-lts - #9385
Open
zyl71 wants to merge 1 commit into
Conversation
….10.12-tls does not exist on the registry; the fix is in 1.10.12-lts
github-actions
Bot
changed the base branch from
main
to
zyl71/advisory-improvement-9385
September 7, 2026 04:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
Current record: Go:github.com/1Panel-dev/1Panel: introduced=0 fixed=1.10.12-tls
Proposed: Go:github.com/1Panel-dev/1Panel: introduced=0 fixed=1.10.12-lts
The record's fixed version
1.10.12-tlsdoes not exist as a tag or as a module version; the real release is v1.10.12-lts (Go proxy, 2024-07-18). Because semver ordersltsbeforetls, the typo makes the record classify the actual fixed release as vulnerable. v1.10.12-lts contains the fix from #5409 (commit ff549a47): the compare API reports the tag as "behind" that commit, the module zip carries the new oneof validation on OrderBy/Order, and the release notes name PR #5409 as the orderBy SQL-injection fix. The previous release v1.10.11-lts (2024-06-26) was cut from a branch without the fix and still has the unvalidated OrderBy field. The 2.x line was released a year later from fixed code and stays outside the range.Release lines: only the 1.x module line existed at the fix date (1.10.x is the LTS line; 1.9.6 and earlier are older, all < 1.10.12-lts and covered by 0 -> 1.10.12-lts). On the 1.10 line: v1.10.10-lts (2024-06-08) and v1.10.11-lts (2024-06-26, tagged after the fix commit but from a diverged branch: compare = diverged, 3 ahead / 19 behind; the only commit touching backend/app/dto/command.go on that branch since May 2024 is #5018, and the module zip shows no validation) are unfixed; v1.10.12-beta (2024-07-11, behind 125) is the first tag carrying the fix, but it is a pre-release; v1.10.12-lts (2024-07-18) is the first final release with it; v1.10.13-lts through v1.10.34-lts all descend from it. The 2.x line (v2.0.0+incompatible, 2025-06-09, compare = behind 729) post-dates the fix and is correctly outside the range.
The advisory text has no "Patches" section, so the fixed version does not come from a maintainer statement. The repository does contain a genuinely mistyped tag, v1.10.9-tls, which may explain the confusion.
Evidence:
OrderBy string+""+json:"orderBy" validate:"required,oneof=name command created_at"+""+`; the same field in v1.10.11-lts.zip has no validate tagThis comes from a systematic comparison of advisory ranges with fix commits and published registry artifacts. Happy to adjust if the maintainers intend otherwise.