[GHSA-3xgx-r9j4-qw9w] dexie: backport to 3.0.4 not reflected - #9381
Open
zyl71 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
changed the base branch from
main
to
zyl71/advisory-improvement-9381
September 7, 2026 04:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
Current record: npm:dexie: introduced=0 fixed=3.2.2 | introduced=4.0.0-alpha.1 fixed=4.0.0-alpha.3
Proposed: npm:dexie: introduced=0 fixed=3.0.4 | introduced=4.0.0-alpha.1 fixed=4.0.0-alpha.3 | introduced=3.1.0-alpha.1 fixed=3.2.2
The prototype-pollution fix was also backported to the 3.0 branch and published as dexie 3.0.4 on 2022-04-29 (commit 3b927b92, the same one-line hunk as 1d655a69; the npm tarball's dist/dexie.js contains the new hasOwn guard, 3.0.3's does not), so "< 3.2.2" wrongly flags 3.0.4. Splitting the range is therefore right, but the second range has to start at 3.1.0-alpha.1 rather than 3.1.0: dexie published twelve 3.1.0-alpha/beta builds (3.1.0-alpha.1 on 2020-11-19 through 3.1.0-beta.13 on 2021-06-07; no final 3.1.0 was ever released) that all predate the fix and would otherwise be reported as unaffected.
Release lines around the fix (2022-04-27): 3.0.x - 3.0.3 (2020-11-18) last unfixed, 3.0.4 (2022-04-29) fixed by the backport. The twelve 3.1.0 pre-releases are all vulnerable; in semver they sort above 3.0.4 and below 3.1.0, so [0, 3.0.4) plus [3.1.0, 3.2.2) would leave them uncovered, which is why the second range starts at 3.1.0-alpha.1. 3.2.x - 3.2.0-beta.1 (2021-06-27) through 3.2.1 (2022-02-16) vulnerable, 3.2.2 (2022-04-27) fixed, 3.2.3 (2023-01-23) later. 4.0.0-alpha.1 and 4.0.0-alpha.2 vulnerable, 4.0.0-alpha.3 fixed (kept from the record), 4.0.0-alpha.4 later. Everything up to 3.0.3 (0.9.9, 1.x, 2.x, 3.0.0-3.0.3 including the alpha/rc builds) stays inside 0 -> 3.0.4.
Maintainer statements: the advisory text says "before 3.2.2, from 4.0.0-alpha.1 and before 4.0.0-alpha.3" and does not mention 3.0.4. The release notes for v3.2.2 and v4.0.0-alpha.3 are both headed "Security fix" and read "Prohibit possible prototype pollution in Dexie.setByKeyPath()", linking commit 1d655a69. There is no GitHub release for v3.0.4, but it was published two days later from the 3.0 branch carrying the identical commit. No statement contradicts this.
Evidence:
hasOwn(obj, currentKeyPath)(also in the 3.2.2 and 4.0.0-alpha.3 tarballs); absent from the 3.0.3, 3.1.0-beta.13, 3.2.1 and 4.0.0-alpha.2 tarballsVersion checks:
if (!innerObj || !hasOwn(obj, currentKeyPath))); confirmed by the compare API and by grepping the tarball. Previous release 3.0.3: not fixed.This comes from a systematic comparison of advisory ranges with fix commits and published registry artifacts. Happy to adjust if the maintainers intend otherwise.