[GHSA-8v8x-cx79-35w7] React Router SSR XSS in ScrollRestoration - #9371
Open
HF-CYGG wants to merge 1 commit into
Open
[GHSA-8v8x-cx79-35w7] React Router SSR XSS in ScrollRestoration#9371HF-CYGG wants to merge 1 commit into
HF-CYGG wants to merge 1 commit into
Conversation
Collaborator
|
Hi there @brophdawg11! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository. This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory |
github-actions
Bot
changed the base branch from
main
to
HF-CYGG/advisory-improvement-9371
September 5, 2026 21:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
Add the missing upstream React Router v7 fix commit for GHSA-8v8x-cx79-35w7.
Commit
c89c32c562a7723c45ee71dab1c892acaf7a608dis the merged commit for upstream PR #14705. InScrollRestoration, it appliesescapeHtml()to bothJSON.stringify(storageKey || SCROLL_RESTORATION_STORAGE_KEY)andJSON.stringify(ssrKey)before embedding them in the inline script throughdangerouslySetInnerHTML. This directly matches the advisory's SSR XSS condition involving untrustedgetKey/storageKeyvalues.The commit's changeset identifies this as a
react-routerpatch. The 7.12.0 changelog lists PR #14705, and the release tag contains this commit, matching the patched React Router version already recorded by the advisory.Supporting sources:
The proposed advisory change only adds the fix commit reference. No changes to package ranges, patched versions, severity, CWE, or the advisory description are proposed.