Repository navigation
Add Database Explorer query policy tests - #196
Draft
hannahcspl wants to merge 1 commit into
Draft
hannahcspl wants to merge 1 commit into
hannahcspl wants to merge 1 commit into
Conversation
Extract the existing query policy into an importable module and add focused Vitest coverage for its supported query handling. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Database Explorer query policy was embedded in the session-starting extension module, making it difficult to test directly. This change extracts the existing behavior into an importable module and adds focused Vitest coverage, without changing which queries the policy accepts or rejects.
Related Issue
Related to #164
Type of Change
Changes Made
Testing
Data Layer Changes
npm run test:unit- all tests pass (52 tests across 5 files)npm run db:generate) for any schema change (N/A; no schema change)Frontend Changes
npm run test:e2e- all tests pass (N/A; no UI changes)data-testidattributes to interactive elements (N/A; no UI changes)npm run build) (N/A; no UI changes)Checklist
Additional Notes
This PR covers the test seam and focused policy tests only. It does not change the query policy's behavior or claim complete coverage of the Database Explorer's read-only contract.
Validation also passed:
npm run lintandnpm run typecheck:all.