Skip to content

Fix Top spenders for fully-discounted billing plans - #429

Open
karpikpl wants to merge 1 commit into
mainfrom
copilot/fix-issue-419
Open

Fix Top spenders for fully-discounted billing plans#429
karpikpl wants to merge 1 commit into
mainfrom
copilot/fix-issue-419

Conversation

@karpikpl

Copy link
Copy Markdown
Collaborator

Fixes #419

Summary

  • Rank Top spenders by net spend unless all loaded net spend is zero
  • Fall back to gross spend for fully-discounted plans so the chart is not empty
  • Add a regression test for all-zero net/non-zero gross billing rows

Validation

  • npm test -- --run --hookTimeout=30000 --reporter=json --outputFile=vitest-results.json --silent (746/746 passed)
  • npm run build

Note: npm run lint -- --quiet currently fails before linting due an existing dependency export error in eslint-plugin-import-x/minimatch. npm audit reports existing dependency advisories on the default branch.

…penders (#419)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: bbf27d66-9aca-451b-85ee-3a32e0775d52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Billing "Top spenders" is always empty on fully-discounted plans — ranks by net cost with no gross fallback

1 participant