(5) chore(lints): silence clippy::pedantic nits across workspace

[daniel-noland]

Drop pre-existing clippy::pedantic warnings flagged under `just lint`'s `-D warnings` so the stack ahead is green throughout.

Mechanical fixes only — no behavioral changes:

• `assert!(x == y)` → `assert_eq!(x, y)` (and `debug_assert_eq!` equivalents)
• `&x` → `x` in `write!` / `println!` arguments (`useless_borrows_in_formatting`)
• `"{}", x` → `"{x}"` implicit format args (`uninlined_format_args`)
• `#[allow(dead_code)]` on `Egress` helpers (kept for the planned egress NF work; the existing `#[allow]` on `Egress::new` already signaled the intent)

Touches: config, dataplane (egress), flow-entry, flow-filter, lpm, mgmt, nat, net, routing.

Precursor for #1562 (DPDK scaffolding removal) and #1555 (threading rewrite).

[Copilot]

Pull request overview

This PR focuses on making just lint green under -D warnings by removing clippy::pedantic nits across the workspace, while also tightening the project-wide “use the concurrency facade” rule and improving cross/emulated test ergonomics (qemu-user + a shared emulated cfg).

Changes:

• Replaces direct std::sync::* usage with concurrency::sync::* (plus enforces via clippy disallowed-types + a Semgrep/opengrep rule).
• Standardizes pedantic-friendly patterns (e.g., assert_eq!, debug_assert_eq!, uninlined format args, useless borrows in formatting) across many crates/tests.
• Improves model-checking/cross-test support: introduces emulated cfg, adds a target runner script for qemu-user, and updates shuttle handling to use a portfolio runner.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tracectl/src/control.rs	Switches sync imports to concurrency::sync and removes .unwrap() on locks.
tracectl/Cargo.toml	Adds concurrency dependency.
sysfs/src/lib.rs	Uses concurrency::sync::LazyLock.
sysfs/Cargo.toml	Adds concurrency dependency.
scripts/test-runner.sh	Adds target runner wrapper that uses qemu-user when host/target arch differs.
scripts/doc/custom-header.html	Bumps KaTeX CDN URLs/integrity metadata.
routing/src/router/rio.rs	Uses concurrency::sync::Arc and updates test ignore gating to emulated.
routing/src/router/ctl.rs	Uses concurrency::sync::Arc.
routing/src/rib/vrftable.rs	Gates traced_test under not(emulated).
routing/src/rib/nexthop.rs	Gates traced_test under not(emulated) and modernizes formatting.
routing/src/interfaces/mod.rs	Modernizes formatting (println!("{iftable}")).
routing/src/frr/test.rs	Gates traced_test under not(emulated) and updates ignore rationale.
routing/src/frr/renderer/vrf.rs	Removes needless borrow in formatting.
routing/src/frr/renderer/interface.rs	Removes needless borrow in formatting.
routing/src/frr/renderer/bgp.rs	Uses inline format args / removes needless borrows.
routing/src/frr/frrmi.rs	Simplifies match to ? propagation.
routing/src/fib/test.rs	Moves toward concurrency::* types and adds model-checker-friendly budgets.
routing/src/fib/fibtype.rs	Uses assert_ne! for pedantic compliance.
routing/src/config/mod.rs	Gates traced_test under not(emulated) and modernizes formatting.
routing/src/cli/handler.rs	Uses concurrency::sync::Arc.
routing/src/atable/resolver.rs	Switches ignore gating to emulated.
routing/Cargo.toml	Adds loom/shuttle feature wiring to concurrency.
npins/sources.json	Updates pinned sources (KaTeX, dplane-plugin, nixpkgs, rust-overlay).
nix/profiles.nix	Introduces host-arch, computes is-emulated-test, and sets --cfg=emulated for emulated tests.
nix/pkgs/dplane-plugin/default.nix	Drops a now-unneeded musl workaround patch.
net/src/packet/hash.rs	Adjusts cfg_select from miri to emulated.
net/src/buffer/test_buffer.rs	Uses debug_assert_eq! for clearer invariant checks.
nat/src/stateless/test.rs	Gates traced_test under not(emulated) and modernizes formatting.
nat/src/stateless/setup/range_builder.rs	Uses debug_assert_eq!.
nat/src/stateful/test.rs	Gates traced_test under not(emulated).
nat/src/stateful/apalloc/test_alloc.rs	Reworks concurrency tests to #[concurrency::test] and documents loom/shuttle constraints.
nat/src/stateful/apalloc/port_alloc.rs	Uses concurrency::thread::ThreadId + concurrency::thread::current() and minor iteration cleanup.
nat/src/stateful/apalloc/mod.rs	Uses assert_eq!.
nat/src/portfw/test.rs	Gates traced_test under not(emulated) and uses assert_ne! where appropriate.
nat/src/portfw/portfwtable/portrange.rs	Uses debug_assert_eq!.
nat/src/portfw/portfwtable/objects.rs	Gates traced_test under not(emulated).
nat/src/portfw/portfwtable/access.rs	Gates traced_test under not(emulated).
nat/src/lib.rs	Adds loom-only arbitrary_self_types gate for loom Arc newtype compatibility.
nat/Cargo.toml	Simplifies shuttle feature surface; adds loom passthrough.
miri.just	Adds shared --cfg=emulated and adjusts RUSTFLAGS concatenation.
mgmt/tests/reconcile.rs	Uses concurrency::sync::Arc and documents intentional std::sync::Mutex usage.
mgmt/src/vpc_manager/mod.rs	Uses concurrency::sync::Arc.
mgmt/src/tests/mgmt.rs	Gates traced_test under not(emulated).
mgmt/src/processor/mgmt_client.rs	Uses concurrency::sync::Arc.
mgmt/src/processor/k8s_less_client.rs	Uses concurrency::sync::Arc.
mgmt/src/processor/k8s_client.rs	Uses concurrency::sync::Arc.
mgmt/src/processor/gwconfigdb.rs	Uses concurrency::sync::Arc.
mgmt/src/processor/confbuild/router.rs	Uses concurrency::sync::Arc.
mgmt/src/processor/confbuild/namegen.rs	Removes needless borrows in formatting.
lpm/src/prefix/mod.rs	Uses assert_eq!/assert_eq!(.., Some(..)) for pedantic compliance.
left-right-tlcache/src/lib.rs	Uses concurrency::sync::Mutex and removes .unwrap() on facade lock.
left-right-tlcache/Cargo.toml	Adds concurrency dev-dependency.
k8s-less/src/local.rs	Gates traced_test under not(emulated).
k8s-intf/src/client.rs	Uses concurrency::sync::Arc.
k8s-intf/src/bolero/support.rs	Adjusts cfg_select from miri to emulated.
k8s-intf/Cargo.toml	Makes concurrency an optional dep for the client feature.
justfile	Updates nextest filter logic for shuttle/loom runs.
interface-manager/src/lib.rs	Uses concurrency::sync::Arc.
interface-manager/Cargo.toml	Adds concurrency dependency.
flow-filter/src/tests.rs	Gates traced_test under not(emulated).
flow-filter/src/setup.rs	Simplifies map iteration (overlaps.keys()).
flow-entry/src/flow_table/table.rs	Adjusts timer gating for loom/shuttle and refactors shuttle tests to #[concurrency::test].
flow-entry/src/flow_table/nf_lookup.rs	Adjusts cfg_select from miri to emulated.
flow-entry/Cargo.toml	Adds loom passthrough; simplifies shuttle feature surface.
dpdk/src/acl/mod.rs	Uses concurrency::sync::Arc / concurrency::thread.
dpdk/src/acl/config.rs	Adds target-arch ignore rationale for a known cross-aarch64 bindgen discrepancy.
default.nix	Plumbs host-arch and adds qemu-user to build inputs.
dataplane/src/runtime.rs	Moves old main runtime logic into a module and uses concurrency::sync::Arc.
dataplane/src/packet_processor/egress.rs	Adds #[allow(dead_code)] on egress helper(s) as planned scaffolding.
dataplane/src/main.rs	Gates the dataplane binary out under loom and delegates to runtime::main().
dataplane/src/drivers/dpdk.rs	Fixes CmdArgs import path (args::CmdArgs).
dataplane/Cargo.toml	Adds a loom feature for workspace-level feature unification.
config/src/utils/collapse.rs	Adjusts cfg_select from miri to emulated.
config/src/gwconfig.rs	Switches ArcSwap usage to concurrency::slot::Slot + uses concurrency::sync::Arc.
config/src/external/overlay/vpcpeering.rs	Uses concurrency::sync::LazyLock for static empty set.
config/src/display.rs	Removes needless borrow in formatting.
config/Cargo.toml	Adds concurrency dependency.
concurrency/tests/thread_scope.rs	Updates shuttle gating (portfolio includes PCT) + allows disallowed std types in tests.
concurrency/tests/stress_dispatch.rs	Updates docs/gating for shuttle portfolio runner and allows disallowed std types.
concurrency/tests/scope_property.rs	Allows disallowed std types in tests.
concurrency/tests/quiescent_shuttle.rs	Allows disallowed std types in tests.
concurrency/tests/quiescent_protocol.rs	Allows disallowed std types in tests.
concurrency/tests/quiescent_properties.rs	Allows disallowed std types in tests.
concurrency/tests/quiescent_model.rs	Updates shuttle gating and docs for portfolio runner.
concurrency/tests/arc_weak.rs	Updates shuttle gating and docs for portfolio runner.
concurrency/src/thread/mod.rs	Refines loom thread surface, adds a loom stack-sized spawn shim, and adds BuilderExt::spawn_scoped.
concurrency/src/thread/loom_scope.rs	Routes loom scoped thread spawning through the new loom spawn shim.
concurrency/src/sync/std_backend.rs	Re-exports LazyLock and allows disallowed std types within the facade.
concurrency/src/sync/shuttle_backend.rs	Re-exports LazyLock/OnceLock from std with explicit allow.
concurrency/src/sync/parking_lot_backend.rs	Re-exports LazyLock from std with explicit allow.
concurrency/src/sync/mod.rs	Updates docs to reflect shuttle portfolio runner (Random+PCT, optional DFS).
concurrency/src/sync/loom_backend.rs	Re-exports LazyLock from std with explicit allow.
concurrency/src/stress.rs	Switches shuttle backend to PortfolioRunner and adds a loom stack-size workaround.
concurrency/src/slot.rs	Adds load() helpers matching ArcSwap ergonomics across backends.
concurrency/src/quiescent.rs	Allows disallowed std types (needed by internal design).
concurrency/Cargo.toml	Simplifies shuttle feature surface (portfolio runner) and updates feature docs.
concurrency-macros/src/lib.rs	Updates #[concurrency::test] expansion/docs to match shuttle portfolio runner.
common/src/cliprovider.rs	Uses Slot::load() in provider impl.
clippy.toml	Disallows direct std sync lock types to enforce concurrency::sync usage.
cli/src/cliproto.rs	Switches ignore gating to emulated.
cli/Cargo.toml	Adds concurrency dependency.
cli/bin/terminal.rs	Uses concurrency::sync::Arc.
cli/bin/main.rs	Uses concurrency::sync::Arc.
cli/bin/completions.rs	Uses concurrency::sync::Arc.
Cargo.toml	Bumps a few dependency versions (e.g., netgauze, serde_json).
Cargo.lock	Updates lockfile accordingly.
.semgrep/rules/no-std-sync-direct.yaml	Adds path-aware enforcement for avoiding std::sync directly.
.gitignore	Ignores qemu-user core dumps.
.github/workflows/lint-opengrep.yml	Runs opengrep with auto + local rules.
.github/workflows/dev.yml	Adds cross label, cross-qemu test step, and sticky PR comment surfacing cross failures.
.github/workflows/bump.yml	Labels bump PRs with ci:+cross/full.
.github/actions/sticky-pr-comment/action.yml	Adds a composite action for marker-keyed sticky PR comments.
.config/nextest.toml	Adds a cross-qemu profile.
.cargo/config.toml	Registers emulated cfg and configures per-target runners via scripts/test-runner.sh.

Comments suppressed due to low confidence (2)

flow-entry/src/flow_table/table.rs:869

confidence: 9
tags: [style]

These assertions will still trigger clippy::assertions_on_constants / clippy::bool_comparison-style pedantic lint; use `assert_eq!` for clearer failure output and to match the rest of the mechanical pedantic cleanups in this PR.

            assert!(result.0 == flow_key1);
        }));

        handles.push(thread::spawn(move || {
            let flow_info = FlowInfo::new(flow_key2, five_seconds_from_now);
            flow_table_clone2.insert(flow_info).unwrap();
            let result = flow_table.remove(&flow_key2).unwrap();
            assert!(result.0 == flow_key2);
        }));

**flow-entry/src/flow_table/table.rs:823**
* ```yaml
confidence: 8
tags: [style]

Typo in comment: “Cancellled” has an extra “l”, which can make grep/search for the status name harder.

            // After all threads, flow[0] should be expired/gone (expirer thread ran).
            // Since timers are not started in shuttle tests, the flow should be there
            // but appear as Expired or Detached. Re-inserting a flow makes it active again,
            // therefore, the only non-feasible status is Cancellled.
            let found = flow_table.lookup(&flow_keys[0]).unwrap();
            assert_ne!(found.status(), FlowStatus::Cancelled);