Repository navigation
chore(ui-react): move to design-core 10 and its control sizes - #16153
Merged
PavelLaptev merged 1 commit intoSep 29, 2026
Merged
Conversation
design-core 10 renames the control heights after the job rather than the component: --size-button becomes --size-control (28px) and --size-button-sm becomes --size-control-sm (20px). --size-tag now points at --size-control-sm and is kept for Tag and Badge, which are not controls. Button's heights and its icon-only width, and Field's control, read --size-control instead of a 28px literal; the small Button reads --size-control-sm instead of borrowing --size-tag. FileList follows the rename. Lite's diff search controls, PR panel section header and verdict slot, and a row's meta items were sized to match a small button through --size-tag; they now name --size-control-sm directly. Every value is unchanged.
|
This pull request changes Lite's CSS. If the change shows on screen, before/after screenshots make it reviewable without checking the branch out — drag them into a comment, or use the |
|
🎩 Your Storybook has been served
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves ui-react, Lite and but-mcp-app to design-core 10 (gitbutlerapp/design-core#51), which names control heights after the job, not the component.
--size-button→--size-control(28px),--size-button-sm→--size-control-sm(20px);--size-tagnow points at--size-control-smand is left to Tag and Badge--size-controlinstead of a28pxliteral; the small Button reads--size-control-sminstead of borrowing--size-tag--size-control-smdirectly