Repository navigation
Source Node from pnpm - #53
Merged
Merged
Conversation
Match gitbutler (b9c477d030, 75482b7ddb): package.json pins pnpm (packageManager) and Node (devEngines.runtime), and pnpm installs that Node locally and in CI. Replaces .nvmrc and the floating `pnpm/action-setup version: latest`. - Workflows: pnpm/setup at gitbutler's pinned SHA replaces pnpm/action-setup + actions/setup-node. - release.yml: publish and version check use pnpm. The Node pnpm installs has no npm; pnpm publish supports trusted publishing (OIDC). - postprocess-light-dark.mjs: run Terrazzo via `pnpm exec`, not npx. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
No token changesThe export rewrote its No CSS custom properties changed. |
Collaborator
|
👍 feel free to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches gitbutler (b9c477d030, 75482b7ddb): pnpm pins and installs Node, replacing
.nvmrcfrom #52.Why
package.json, and the lockfile records the exact Node build.version: latest, so a new pnpm major could break--frozen-lockfileand block releases.Changes
package.json: addpackageManager(pnpm 12.8.1) anddevEngines.runtime(Node ^24)..nvmrc.pnpm/setup(same pinned SHA as gitbutler) replacespnpm/action-setupandsetup-node.release.yml:npm viewandnpm publishbecomepnpm viewandpnpm publish, because the Node pnpm installs has no npm.pnpm execinstead ofnpx.tokens.cssis unchanged. No version bump, so merging doesn't publish.Notes
The next release is the first real test of trusted publishing through
pnpm publish. If it fails, nothing is published; addsetup-nodeback torelease.ymland re-run.🤖 Generated with Claude Code