Repository navigation
fix: keep double-click selections inside the message - #29
Merged
Merged
Conversation
Full width behind a dimmed backdrop instead of a 340px popover clamped to the left edge, no keyboard on open, finger-sized cells and tone buttons, and lifted above the keyboard while searching. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SwiftPM 6.4's swift-build backend appends macOS -sdk/-target after swift-rs's iOS overrides, so Tauri's Swift package compiles against AppKit and fails on OpenGLES/EAGL.h. npm run ios / ios:build now put scripts/ios-shim first on PATH, which adds --build-system native. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drops the header info button on phones; the avatar and name become the way into room info instead. Desktop keeps the button. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A light impact on every reaction (chip, action sheet, picker) and a medium one when a long-press opens the message sheet. Uses tauri-plugin-haptics, compiled and permitted on Android and iOS only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
WebKit's word/paragraph selection doesn't stop at the edge of a .selectable island in the user-select:none body, so multi-clicking the last message ran the selection into the composer and copied the draft. Clamp double/triple-click selections to the element they started in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Double- or triple-clicking a message to copy it also selected the composer's draft text, so ⌘C copied both.
Why
The body is
user-select: none, and only.selectableareas allow selecting. WebKit's word/paragraph selection doesn't stop at the edge of a selectable area. On the last message it ran on through the unselectable chrome into the composer.Change
src/lib/selection.ts: amouseuplistener that, for multi-clicks only (detail >= 2), trims the selection to the.selectableelement it started in.main.tsx.Testing
tscpasses.🤖 Generated with Claude Code