Remove golangci-lint tool dependency - #61
Merged
Merged
Conversation
Tool dependencies share the application module graph, so bumping the linter forced compatibility pins on its own dependencies. CI installs the pinned release binary through golangci-lint-action instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go.modcarriedgolangci-lintas a tool dependency, which puts the linter's own dependencies in the application module graph, so bumping the linter forces compatibility pins on requirements the application does not use. Upstream recommends installing release binaries instead ofgo tool.CI now installs a pinned binary through
golangci-lint-actionatv2.14.0, and thelintjob gets an explicitcontents: read. Removing the directive and runninggo mod tidydrops the linter dependency tree fromgo.modandgo.sum.The
lintmake target now calls the installedgolangci-lintbinary.