Repository navigation
ci: remove the workflows no required check depends on - #3301
Conversation
Its only job was the Linux without systemd check, which is no longer required on main. CircleCI's go-build still tests the systemd platform. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MK2zsdNEWogx6K46ns8n2Z
|
Desk review: PASS for head
Validation: exact-head source/diff inspection, repository-wide reference search, |
Chart tests stay covered by the required CircleCI chart-test job. Readme link checks and the scorecard run no longer in CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MK2zsdNEWogx6K46ns8n2Z
teemow
left a comment
There was a problem hiding this comment.
Review: approved
Head reviewed: 1b36a10d83b31762a34351f699396ae7eeaabf6d
No blocking findings.
The diff against main contains only the four requested workflow deletions (160 deleted lines). The active default-branch rulesets require none of their checks; there are no legacy branch-protection rules or required-workflow rules. Repository references introduce no dependency on the deleted workflows: the remaining chart-tests reference is a test fixture, and the Makefile's execute-chart-tests comment describes a separate job.
The description accurately states the coverage loss: nosystemd vet/race tests disappear, README link checking and its scheduled reporting disappear, and OSSF Scorecard automation disappears. Required CircleCI chart-test independently runs make helm-test. The description also acknowledges loss of the observed browser-test execution and that deletion does not fix its intermittent failure. It explicitly records that the three generated workflows can return on file alignment until generation is disabled separately.
Review only; no code changed or merge performed.
teemow
left a comment
There was a problem hiding this comment.
Review: approved
Head reviewed: e9de79b8306a4d43e89f5a66de4a7daae7d26a8a
No blocking findings.
The diff against main (e26a99f76ac7bc0a58073b89c161f245524d094d) is exactly the deletion of .github/workflows/platforms.yaml, .github/workflows/zz_generated.chart_tests.yaml, .github/workflows/zz_generated.check_readme_links.yaml, and .github/workflows/zz_generated.run_ossf_scorecard.yaml: four files, zero additions, 160 deletions. This head merges main into the previously reviewed head.
The active main rules require none of the removed workflows' checks. The required ci/circleci: chart-test remains defined in .circleci/custom.yml and runs make helm-test. Repository-wide reference inspection found no operational dependency on the deleted workflows; the remaining chart workflow name in cmd/reviewedmergeroots_test.go is static fixture data.
The description accurately discloses the removed nosystemd vet/race-test coverage, README link checking, and Scorecard execution, with no claimed replacements for those losses. It identifies the remaining CircleCI chart and systemd test coverage, acknowledges the browser-test coverage loss, and explicitly warns that alignment can regenerate the three generated files. The deletion does not establish or fix the browser timeout's cause.
Removes four GitHub workflows that no required check of
maindepends on, so they can no longer block CI:platforms.yamlgo vetandgo test -raceunder-tags nosystemdgo-buildtests the systemd platformzz_generated.chart_tests.yamlchart-tests / helm-testci/circleci: chart-testzz_generated.check_readme_links.yamlzz_generated.run_ossf_scorecard.yamlLinux without systemdwas taken out of the required checks ofmainfirst; the other three were never required.mainis red onLinux without systemdat 5ac5659 becauseTestUploadTargetBrowsertimed out launching Chromium, an intermittent failure in about 3 of 50 recent runs. Its cause is not established, and this does not fix it. That job was, as far as observed, the only CI run of the test, which skips where no Chromium is installed.Known limit
The three
zz_generatedfiles come back on the next files alignment until generation is turned off for this repository. That is follow-up work outside this pull request.🤖 Generated with Claude Code
https://claude.ai/code/session_01MK2zsdNEWogx6K46ns8n2Z