Skip to content

ci: remove the workflows no required check depends on - #3301

Merged
teemow merged 4 commits into
mainfrom
remove-platforms-e0d24601
Nov 6, 2026
Merged

teemow merged 4 commits into
mainfrom
remove-platforms-e0d24601

Conversation

@teemow

@teemow teemow commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Removes four GitHub workflows that no required check of main depends on, so they can no longer block CI:

Workflow What goes What still covers it
platforms.yaml go vet and go test -race under -tags nosystemd nothing in CI builds the stub platform any more; CircleCI go-build tests the systemd platform
zz_generated.chart_tests.yaml chart-tests / helm-test the required ci/circleci: chart-test
zz_generated.check_readme_links.yaml README link check nothing
zz_generated.run_ossf_scorecard.yaml OSSF Scorecard run nothing

Linux without systemd was taken out of the required checks of main first; the other three were never required.

main is red on Linux without systemd at 5ac5659 because TestUploadTargetBrowser timed out launching Chromium, an intermittent failure in about 3 of 50 recent runs. Its cause is not established, and this does not fix it. That job was, as far as observed, the only CI run of the test, which skips where no Chromium is installed.

Known limit

The three zz_generated files come back on the next files alignment until generation is turned off for this repository. That is follow-up work outside this pull request.

🤖 Generated with Claude Code

https://claude.ai/code/session_01MK2zsdNEWogx6K46ns8n2Z

Its only job was the Linux without systemd check, which is no longer
required on main. CircleCI's go-build still tests the systemd platform.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MK2zsdNEWogx6K46ns8n2Z
@teemow

teemow commented Nov 6, 2026

Copy link
Copy Markdown
Member Author

Desk review: PASS for head 91d1d173007fcce8d082e1388e94f0485332c20d. No blocking findings in the requested scope.

  • The entire diff is deletion of .github/workflows/platforms.yaml (46 lines), with no other file changes. Its sole job was Linux without systemd, running go vet -tags nosystemd ./... and go test -race -tags nosystemd ./... on Ubuntu for pull requests, merge groups and pushes to main.
  • Searched the tracked tree at this head, including docs, scripts, tests, Makefiles, generated workflows and CircleCI configuration: no dangling workflow filename, job-name or workflow dependency remains. The nosystemd build tags and the local build example in docs/development.md still describe supported source paths, rather than referring to the deleted workflow.
  • Read the effective GitHub branch rules for main: Linux without systemd is absent from required status checks. Legacy branch protection returns “Branch not protected”; required checks are supplied by rulesets. This deletion therefore leaves no required check waiting for the removed job.
  • Coverage lost: the explicit Linux nosystemd build, vet and race-test coverage. No remaining CI job explicitly compiles Linux with -tags nosystemd. CircleCI architect/go-build still runs the ordinary Linux make test path and cross-compiles Linux/macOS/Windows. Non-Linux builds exercise some shared stub source, but do not replace the Linux-tagged nosystemd build and tests.

Validation: exact-head source/diff inspection, repository-wide reference search, git diff --check, and live effective required-check inspection. No source changes or pushes; no build/test rerun for this workflow-only deletion. This verdict is a scope review, not a declaration that all PR CI has completed.

teemow and others added 2 commits November 6, 2026 09:56
…4601

* origin/main:
  fix(agents): create one-repository sessions in managed worktrees (#2358)
  feat: monitor owned issues and triage external authors (#2687)
Chart tests stay covered by the required CircleCI chart-test job.
Readme link checks and the scorecard run no longer in CI.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MK2zsdNEWogx6K46ns8n2Z
@teemow teemow changed the title ci: remove the platforms workflow ci: remove the workflows no required check depends on Nov 6, 2026

@teemow teemow left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: approved
Head reviewed: 1b36a10d83b31762a34351f699396ae7eeaabf6d

No blocking findings.

The diff against main contains only the four requested workflow deletions (160 deleted lines). The active default-branch rulesets require none of their checks; there are no legacy branch-protection rules or required-workflow rules. Repository references introduce no dependency on the deleted workflows: the remaining chart-tests reference is a test fixture, and the Makefile's execute-chart-tests comment describes a separate job.

The description accurately states the coverage loss: nosystemd vet/race tests disappear, README link checking and its scheduled reporting disappear, and OSSF Scorecard automation disappears. Required CircleCI chart-test independently runs make helm-test. The description also acknowledges loss of the observed browser-test execution and that deletion does not fix its intermittent failure. It explicitly records that the three generated workflows can return on file alignment until generation is disabled separately.

Review only; no code changed or merge performed.

@teemow teemow left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: approved
Head reviewed: e9de79b8306a4d43e89f5a66de4a7daae7d26a8a

No blocking findings.

The diff against main (e26a99f76ac7bc0a58073b89c161f245524d094d) is exactly the deletion of .github/workflows/platforms.yaml, .github/workflows/zz_generated.chart_tests.yaml, .github/workflows/zz_generated.check_readme_links.yaml, and .github/workflows/zz_generated.run_ossf_scorecard.yaml: four files, zero additions, 160 deletions. This head merges main into the previously reviewed head.

The active main rules require none of the removed workflows' checks. The required ci/circleci: chart-test remains defined in .circleci/custom.yml and runs make helm-test. Repository-wide reference inspection found no operational dependency on the deleted workflows; the remaining chart workflow name in cmd/reviewedmergeroots_test.go is static fixture data.

The description accurately discloses the removed nosystemd vet/race-test coverage, README link checking, and Scorecard execution, with no claimed replacements for those losses. It identifies the remaining CircleCI chart and systemd test coverage, acknowledges the browser-test coverage loss, and explicitly warns that alignment can regenerate the three generated files. The deletion does not establish or fix the browser timeout's cause.

@teemow
teemow merged commit 8209ab4 into main Nov 6, 2026
13 checks passed
@teemow
teemow deleted the remove-platforms-e0d24601 branch November 6, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant