Repository navigation
fix: remove show_link argument from plotly.offline.plot() (closes #468) - #469
Merged
Merged
Conversation
plotly 4.2.3 removed the show_link parameter from plotly.offline.plot(), which causes TypeError when rendering plots in QGIS DataPlotly plugin. Remove show_link=False from all three call sites in plot_factory.py. Fixes ghtmtt#468
Contributor
Author
|
Created a fix for this issue — removed |
Owner
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plotly 4.2.3 removed the
show_linkparameter fromplotly.offline.plot(), which causes aTypeErrorwhen rendering plots in the QGIS DataPlotly plugin.Fix
Remove
show_link=Falsefrom all three call sites inDataPlotly/core/plot_factory.py:build_html()methodTesting
Verified syntax is correct via
python3 -m py_compile.Related Issue
Fixes #468