memory : return an error instead of aborting on multi-range on-device state save - #28209
Draft
vahpetr wants to merge 1 commit into
Draft
memory : return an error instead of aborting on multi-range on-device state save#28209vahpetr wants to merge 1 commit into
vahpetr wants to merge 1 commit into
Conversation
|
Hi @vahpetr, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
github-actions
Bot
removed
the
draft
vahpetr
force-pushed
the
abort-fix-pr
branch
from
September 1, 2026 22:10
bee8632 to
01103cb
Compare
… state save state_write aborted the process when an on-device sequence state spans more than one cell range. Throw instead; state_seq_get_size/get_data already catch and return 0.
vahpetr
force-pushed
the
abort-fix-pr
branch
from
September 1, 2026 22:11
01103cb to
3ac6e1e
Compare
Author
|
used an assistant to help locate the abort and draft the change; I reviewed and understand it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
state_write in llama-memory-recurrent.cpp calls GGML_ABORT when an on-device sequence state spans more than one cell range, which takes the whole process down. The single-range limit is real (#23520), but a fragmented state should be recoverable, not fatal.
This replaces the abort with a throw — state_seq_get_size / state_seq_get_data already catch it and return 0. Unchanged for the common single-range case. The abort only shows up with on-device state usage (e.g. #28118) at -np > 1.