metal : assert shared memory padding - #27951
Merged
Merged
Conversation
github-actions
Bot
added
ggml
jbooth
pushed a commit
to jbooth/llama.cpp
that referenced
this pull request
Aug 30, 2026
* metal : assert shared memory padding * cont : add ref
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
pick #27944
Per the Metal docs the threadgroup memory size should be multiple of 16 bytes. Add assert and adjust a few kernels that were violating this.
This is slightly different from #27944 where the padding is always done implicitly. For now, I want the callers of
ggml_metal_encoder_set_threadgroup_memory_size()to be aware if this requirementRequirements