Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Moderate findings remain for watcher failure handling and regression-test coverage.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Updates Docker startup handling so early lightningd failures propagate and containers can restart automatically.
Changes:
- Replaces indefinite RPC monitoring with bounded polling.
- Adds lifecycle regression tests.
- Runs the tests in Docker CI.
| File | Summary |
|---|---|
tests/docker-entrypoint-test.sh |
Tests early failure and normal startup lifecycles. |
docker-entrypoint.sh |
Detects early daemon exits and propagates status. |
.github/workflows/docker.yml |
Runs entrypoint lifecycle tests in CI. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+27
to
+31
| cat >"$test_dir/bin/inotifywait" <<'EOF' | ||
| #!/usr/bin/env bash | ||
| sleep 0.05 | ||
| exit 2 | ||
| EOF |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
inotifywait --monitorstartup block with a bounded wait looplightningdexits before creatinglightning-rpcand propagate its exit statusThis allows the Core Lightning app's existing
restart: on-failurepolicy to recover from transient Bitcoin RPC startup failures instead of leaving a wrapper-only container reported as running.Fixes #1
Testing