Enable type-aware Oxlint rules turned off in #1556 #1573
Copy link
Copy link
Closed
Description
#1556 turns on type-aware Oxlint (oxlint-tsgolint). Nine type-aware rules from the correctness category already had violations, so that PR sets them to off at the root of .oxlintrc.json to keep lint green. Most of them should be turned back on, starting with the ones that catch runtime bugs.
Counts were measured on the #1556 branch and are approximate.
Runtime safety
| Rule | Hits | Where |
|---|---|---|
typescript/no-floating-promises |
67 | mostly node:test calls in scripts/ and .github/tests; cli 8, mcp-cloudflare 5, mcp-core 1 |
typescript/no-misused-spread |
12 | cli 7, mcp-cloudflare 2, mcp-core 1, smoke-tests 1, scripts 1 |
typescript/unbound-method |
56 | cli 40, mcp-cloudflare 15, mcp-core 1 |
typescript/no-base-to-string |
158 | cli 131, mcp-core 26, mcp-cloudflare 1 |
typescript/restrict-template-expressions |
47 | mcp-core 25, cli 16, mcp-cloudflare 3, others 3 |
typescript/await-thenable |
275 | cli 274 (await on calls that are now synchronous), mcp-test-client 1 |
typescript/require-array-sort-compare |
2 | mcp-cloudflare 1, .github/tests 1 |
Type hygiene
| Rule | Hits | Where |
|---|---|---|
typescript/no-redundant-type-constituents |
17 | mcp-core 10, cli 5, mcp-cloudflare 2 |
typescript/no-duplicate-type-constituents |
2 | mcp-core 1, cli 1 |
To list the current hits for a rule, delete its off entry from .oxlintrc.json and run pnpm exec oxlint ..
apps/local/.oxlintrc.json is a separate config. It doesn't inherit these off entries, so it already reports no-floating-promises as warnings.
via byk.
--
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Activity
linear-code commentedon Oct 21, 2026
MCP-1102
fix: Require return await repo-wide
chore(lint): Enable type-aware Oxlint rules disabled in #1556