Repository navigation
Conversation
Flpvoigt
marked this pull request as ready for review
October 26, 2026 17:21
jjbayer
approved these changes
Oct 27, 2026
jjbayer
left a comment
jjbayer
left a comment
Member
There was a problem hiding this comment.
Code looks OK to me, and percent_encoding was already in our dependency tree (verified with cargo tree).
I would also push to fix this at the source though. It seems like the dart SDK strips file:// but does not decode the URL: https://github.com/dart-lang/sdk/blob/main/runtime/vm/debug_info.cc#L35 cc @buenaflor
| return Some(BufReader::new(file)); | ||
| } | ||
|
|
||
| let decoded = percent_decode_str(path).decode_utf8().ok()?; |
Member
There was a problem hiding this comment.
Might be worth a code comment why we do this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes getsentry/sentry-dart-plugin#377
Testing
git diff --check