Repository navigation
ref(symcache): Add Type::UNKNOWN sentinel constant - #1107
Merged
szokeasaurusrex merged 1 commit intoOct 28, 2026
Merged
szokeasaurusrex merged 1 commit into
szokeasaurusrex merged 1 commit into
Conversation
loewenheim
approved these changes
Oct 23, 2026
Dav1dde
approved these changes
Oct 23, 2026
Member
|
Late to the party, but the void/unknown split requires checking every path that previously conflated the two. Reading this now, It looks like the original |
szokeasaurusrex
force-pushed
the
szokeasaurusrex/constant-for-unknown-type
branch
from
October 23, 2026 12:39
701e51d to
063952e
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/constant-for-unknown-type
branch
from
October 23, 2026 15:16
063952e to
3896943
Compare
Member
Author
Define `v9::raw::Type::UNKNOWN` (`u32::MAX`) alongside `Type::VOID` (`u32::MAX - 1`) and use `Type::UNKNOWN` in `SymCacheConverter` when a variable or referenced type cannot be resolved.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/constant-for-unknown-type
branch
from
October 27, 2026 11:53
3896943 to
de6af2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define
v9::raw::Type::UNKNOWN(u32::MAX) alongsideType::VOID(u32::MAX - 1) and useType::UNKNOWNinSymCacheConverterwhen a variable or referenced type cannot be resolved.Stack created with GitHub Stacks CLI • Give Feedback 💬