ref(resolvers): remove unused resolver declarations - #8451
Merged
Conversation
pbhandari
approved these changes
Sep 10, 2026
MeredithAnya
force-pushed
the
meredith/convert-resolvers
branch
from
September 10, 2026 18:34
f6df8b8 to
efffbe7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
ref(resolvers): remove unused resolver declarationsref(resolvers): inline the trace item stats resolverref(resolvers): inline the time series resolverref(resolvers): inline the trace item table resolverref(resolvers): remove the TraceItemDataResolver abstractionWhat
Deletes the
ResolverAttributeNames,ResolverAttributeValues, andResolverGetTracemarker classes fromsnuba/web/rpc/v1/resolvers/__init__.py, plus the now-unused proto imports and a stale# TODO: Traces, subscriptionscomment.None of these had a concrete subclass left — the endpoints they belonged to were converted away from resolvers earlier (
76d1fed8f,37dc351c3) or never used one. This is registry cleanup ahead of removing the resolver abstraction entirely.🤖 Generated with Claude Code