feat(eap-items): populate name column from sentry.op and sentry.name#8017
Open
phacops wants to merge 1 commit into
Open
feat(eap-items): populate name column from sentry.op and sentry.name#8017phacops wants to merge 1 commit into
phacops wants to merge 1 commit into
Conversation
Populate the new generic `name` column (added in #8016) in the EAP items consumer. The value is sourced per item type from the primary name attribute we commonly filter on: `sentry.op` for spans and `sentry.name` for metrics. The source attribute is still written into the attribute maps as before; this only promotes it into the dedicated indexed column. Declare the `name` column in the eap_items storage and all sibling storages (read-only, downsampled, and DLQ replay) so the read path sees it as well. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Agent transcript: https://claudescope.sentry.dev/share/RnmbvjU4NSsHdJEJwL_H0KFTCm_2y3okwyxmphZmzms
phacops
force-pushed
the
feat/eap-items-populate-name-column
branch
from
da77664 to
a3f3c9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Populate the generic
namecolumn (added in #8016) in the EAP items consumer. The value is sourced per item type from the primary name attribute we commonly filter on, promoting it from the attribute maps into the dedicated bloom-filter-indexed column so those filters can skip granules.Per-item-type source attribute
The column is filled in
EAPItem::try_from(TraceItem), read before the attribute map is consumed:Span→sentry.opMetric→sentry.nameThe source attribute is still written into the attribute maps as before; this only copies it into the dedicated column. In
EAPItemRow/COLUMN_NAMES,namesits betweenitem_idandsampling_weight. The insert uses an explicit column list, so this wire order is independent of the column's physicalAFTER attributes_arrayposition in the table.Storage configuration
Declares the
namecolumn ineap_itemsand all sibling storages (read-only, the three downsampled resolutions and their_rovariants, and DLQ replay) so the read path sees it too.Depends on #8016 for the underlying column and
bf_nameindex.