Skip to content

feat(investigations): Register update_detector and say who can apply it - #128680

Open
wedamija wants to merge 2 commits into
danf/inv-fu-15-update-detector-payloadsfrom
danf/inv-fu-18-update-detector-dry-run
Open

wedamija wants to merge 2 commits into
danf/inv-fu-15-update-detector-payloadsfrom
danf/inv-fu-18-update-detector-dry-run

Conversation

@wedamija

@wedamija wedamija commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click.

This registers the update_detector action kind. Reads say whether the viewer can apply a monitor change, using the detector endpoint's own plan and permission checks.

Depends on #128671

@wedamija
wedamija requested review from a team as code owners October 23, 2026 18:11
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 23, 2026
@wedamija
wedamija requested a review from billyvg October 23, 2026 18:18

@billyvg billyvg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI-assisted review, posted on behalf of @billyvg.

Comment thread src/sentry/investigations/services/action_kinds/update_detector.py Outdated
Comment thread src/sentry/investigations/endpoints/serializers/action_request.py Outdated
@wedamija wedamija changed the title feat(investigations): Register update_detector and check its requests on arrival feat(investigations): Register update_detector and say who can apply it Oct 23, 2026
@sentry

sentry Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Sentry Snapshot Testing

Name Added Removed Changed Renamed Unchanged Skipped Status
sentry-frontend
sentry-frontend
0 0 0 0 760 0 ✅ Unchanged

⚙️ sentry-frontend Snapshot Settings

@wedamija
wedamija force-pushed the danf/inv-fu-15-update-detector-payloads branch from 51f2bcf to d30261b Compare October 23, 2026 23:28
@wedamija
wedamija force-pushed the danf/inv-fu-18-update-detector-dry-run branch from 8c92f3b to 9566cb0 Compare October 23, 2026 23:28
wedamija added a commit that referenced this pull request Oct 23, 2026
Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click.

This adds an endpoint that applies a suggested action request as the current user, or with dryRun only checks whether it would apply. Each action kind does its own checks and change, so the endpoint works the same for every kind.

Depends on #128680
@wedamija
wedamija requested a review from billyvg October 23, 2026 23:41
@wedamija
wedamija force-pushed the danf/inv-fu-18-update-detector-dry-run branch from 9566cb0 to 87799ce Compare October 24, 2026 01:10
wedamija added a commit that referenced this pull request Oct 24, 2026
Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click.

This adds an endpoint that applies a suggested action request as the current user, or with dryRun only checks whether it would apply. Each action kind does its own checks and change, so the endpoint works the same for every kind.

Depends on #128680
Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click.

This registers the update_detector action kind. Reads say whether the viewer can apply a monitor change, using the detector endpoint's own plan and permission checks.

Depends on #128671
…ason

The UI told users Seer can't apply this kind of change for a dynamic monitor, which Seer does apply on static ones. A separate code lets it say why.
@wedamija
wedamija force-pushed the danf/inv-fu-18-update-detector-dry-run branch from 87799ce to 1d4f218 Compare October 24, 2026 03:49
wedamija added a commit that referenced this pull request Oct 24, 2026
Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click.

This adds an endpoint that applies a suggested action request as the current user, or with dryRun only checks whether it would apply. Each action kind does its own checks and change, so the endpoint works the same for every kind.

Depends on #128680

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants