Skip to content

fix(coding-conventions): Refactor relocation API call to use try/catch #126272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −11
Open

fix(coding-conventions): Refactor relocation API call to use try/catch #126272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions static/gsAdmin/views/relocationCreate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,20 +45,18 @@ function RelocationForm() {
// Verify that the promo code exists, has remaining claims, etc.
const promoCode = formData.get('promo_code');
if (typeof promoCode === 'string' && promoCode) {
await promoCodeApi
.requestPromise(`/promocodes-external/${promoCode}`, {
try {
await promoCodeApi.requestPromise(`/promocodes-external/${promoCode}`, {
method: 'GET',
host: cell.locality_url,
})
.catch(error => {
if (error instanceof RequestError && error.status === 403) {
addErrorMessage(PROMO_CODE_ERROR_MSG);

// Ensure that the wrapping `catch` block doesn't try to re-print this error message.
// eslint-disable-next-line unicorn/error-message
throw new Error();
}
});
} catch (error) {
if (error instanceof RequestError && error.status === 403) {
addErrorMessage(PROMO_CODE_ERROR_MSG);
return;
}
throw error;
}
}

// Start the relocation.
Expand Down
Loading