fix(api-conventions): Remove callback API requests from group action creators - #126268
Open
sentry[bot] wants to merge 4 commits into
Open
sentry[bot] wants to merge 4 commits into
sentry[bot] wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 87c8fc7. Configure here.
Contributor
📊 Type Coverage Diff
🔍 2 new type safety issues introduced
This is informational only and does not block the PR. |
Replace the .then/.catch/.finally chains with try/catch/finally around an awaited call. Analytics and cache resets that used to run right after the request was fired now run before the await, so they still happen immediately instead of waiting on the response.
ryan953
approved these changes
Oct 2, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR addresses the
no-callback-api-requestconvention violation instatic/app/actionCreators/group.tsx.The
bulkUpdateandmergeGroupsfunctions were partially migrated to useapi.requestPromisewithasync/await, but they still accepted and forwardedRequestCallbacks(success, error, complete options). This led to a hybrid pattern that violated the coding convention.Changes include:
options: RequestCallbacksparameter frombulkUpdateandmergeGroupsinstatic/app/actionCreators/group.tsx.awaitthe returned promise insidetry/catch/finally. Analytics and cache resets that used to run right after the request was fired now run before theawait, so they still happen immediately. Affected files include:static/app/views/issueList/actions/utils.tsxstatic/app/views/issueDetails/groupPriority.tsxstatic/app/views/issueDetails/actions/index.tsxstatic/app/views/issueList/actions/index.tsxstatic/app/views/issueDetails/actions/shareModal.tsxstatic/app/views/issueDetails/utils.tsxstatic/app/views/issueList/pages/inbox/issuePreview/issuePreviewActions.tsxstatic/app/views/issueDetails/groupSimilarIssues/similarStackTrace/index.tsxRequestCallbacksimport tostatic/app/actionCreators/group.tsxas it is still required by thebulkDeletefunction.static/app/actionCreators/group.spec.tsxto drop the obsolete third argument andawaiteach call.catch, becauseGroupStorealready shows the error alert and the functions now reject on failure.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes CODING-CONVENTIONS-4KW
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this run