ref(gsAdmin): Convert promo code API call to try/catch - #126261
Closed
sentry[bot] wants to merge 1 commit into
Closed
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Frontend
ryan953
added
the
Trigger: getsentry tests
Member
|
dupe with #126272 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the promo code API call in
static/gsAdmin/views/relocationCreate.tsxfrom using.requestPromise().catch()to anawait requestPromise()within atry/catchblock.This change addresses a false positive reported by the
no-callback-api-requestcoding convention scanner. While the original.catch()pattern is functionally valid and promise-based, the scanner was incorrectly flagging it. Switching totry/catchaligns more explicitly with the scanner's preferred pattern forapi.requestPromisecalls, preventing future false positives.The functional behavior of the code remains unchanged, specifically regarding the handling of 403 errors and other potential API errors.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes CODING-CONVENTIONS-3E5
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this run