Skip to content

fix(workflows): Clean invalid condition comparisons - #124230

Draft
sentry-junior[bot] wants to merge 5 commits into
masterfrom
iswf-3455-cleanup-datacondition-comparisons
Draft

sentry-junior[bot] wants to merge 5 commits into
masterfrom
iswf-3455-cleanup-datacondition-comparisons

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Adds a post-deployment data migration for the remaining schema-invalid DataCondition.comparison values tracked by ISWF-3455.

It normalizes only unambiguous integer, resolution, detector, and numeric priority values. Values that cannot be converted safely are logged and left unchanged. Existing named-priority cleanup from ISWF-3433 is not repeated.

This migration now follows 0120_replace_boolean_deescalation_comparisons, which already handles stored boolean de-escalation values, so this PR no longer duplicates that cleanup.

via Junior system actor event.

--

View Junior Session [Sentry]

Co-Authored-By: Kyle Consalus <kyle.consalus@sentry.io>
@linear-code

linear-code Bot commented Sep 11, 2026

Copy link
Copy Markdown

ISWF-3455

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR has a migration; here is the generated SQL for src/sentry/workflow_engine/migrations/0120_cleanup_invalid_data_condition_comparisons.py

for 0120_cleanup_invalid_data_condition_comparisons in workflow_engine

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

@kcons
kcons self-requested a review September 12, 2026 00:51
@kcons

kcons commented Sep 18, 2026

Copy link
Copy Markdown
Member

revisit this, and consider the migration(s) that have already gone through recently.

@github-actions

Copy link
Copy Markdown
Contributor

This PR has a migration; here is the generated SQL for src/sentry/workflow_engine/migrations/0121_cleanup_invalid_data_condition_comparisons.py

for 0121_cleanup_invalid_data_condition_comparisons in workflow_engine

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

@kcons

kcons commented Oct 2, 2026

Copy link
Copy Markdown
Member

rebase please.

…atacondition-comparisons

# Conflicts:
#	migrations_lockfile.txt

Co-Authored-By: Kyle Consalus <kyle.consalus@sentry.io>
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

This PR has a migration; here is the generated SQL for src/sentry/workflow_engine/migrations/0122_cleanup_invalid_data_condition_comparisons.py

for 0122_cleanup_invalid_data_condition_comparisons in workflow_engine

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

@getsantry

getsantry Bot commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry Bot added the Stale label Oct 24, 2026

This branch was successfully deployed

1 active deployment
Preview — 91a3358a Deployed Oct 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant