ref(pr-iter): post the missing-permissions comment through SCM - #123918
Open
joseph-sentry wants to merge 1 commit into
Open
ref(pr-iter): post the missing-permissions comment through SCM#123918joseph-sentry wants to merge 1 commit into
joseph-sentry wants to merge 1 commit into
Conversation
The missing-permissions notice went out through the raw GitHub integration client, the last direct client call left in PR iteration. Route it through the SCM facade like the cap-exhausted comment already does, guarding on the comment protocol so an unsupported provider is skipped rather than raising. The comment_failed metric and log now carry a reason tag naming which step gave up.
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0beed77. Configure here.
| scm_patcher = patch( | ||
| f"{MODULE}.make_scm", | ||
| return_value=MagicMock(spec=CreatePullRequestCommentProtocol), | ||
| ) |
Contributor
There was a problem hiding this comment.
Test SCM stub fails protocol check
Medium Severity
_patch_scm returns a MagicMock that Python 3.13 isinstance does not treat as CreatePullRequestCommentProtocol, so _post_comment always takes the unsupported_provider path. Happy-path tests never post a comment and fail or pass for the wrong reason.
Reviewed by Cursor Bugbot for commit 0beed77. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The missing-permissions notice went out through the raw GitHub integration
client, the last direct client call left in PR iteration. Route it through
the SCM facade like the cap-exhausted comment already does, guarding on the
comment protocol so an unsupported provider is skipped rather than raising.
The comment_failed metric and log now carry a reason tag naming which step
gave up.