Skip to content

fix(ui): Shrink filtered debug image tables #123895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
priscilawebdev wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −22
Draft

fix(ui): Shrink filtered debug image tables #123895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 3 additions & 22 deletions static/app/components/events/interfaces/debugMeta/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,4 @@
import {
Fragment,
useCallback,
useEffect,
useLayoutEffect,
useMemo,
useState,
} from 'react';
import {Fragment, useCallback, useEffect, useMemo, useState} from 'react';
import {useTheme} from '@emotion/react';
import styled from '@emotion/styled';
import {useVirtualizer} from '@tanstack/react-virtual';
Expand Down Expand Up @@ -102,7 +95,6 @@ export function DebugMeta({data, projectSlug, groupId, event}: DebugMetaProps) {
const [scrollContainer, setScrollContainer] = useState<HTMLDivElement | null>(null);
const [filterSelections, setFilterSelections] = useState<FilterSelections>([]);
const [filtersInitialized, setFiltersInitialized] = useState(false);
const [lockHeight, setLockHeight] = useState(false);
const {searchTerm, setSearchTerm} = useDebugMetaSearch();

const {allImages, filterOptions} = useMemo(() => {
Expand Down Expand Up @@ -171,11 +163,6 @@ export function DebugMeta({data, projectSlug, groupId, event}: DebugMetaProps) {
});

const totalSize = virtualizer.getTotalSize();
useLayoutEffect(() => {
if (!lockHeight && totalSize > MAX_HEIGHT) {
setLockHeight(true);
}
}, [totalSize, lockHeight]);

const openDetails = useCallback(
(image: ImageWithCombinedStatus) => {
Expand Down Expand Up @@ -254,7 +241,7 @@ export function DebugMeta({data, projectSlug, groupId, event}: DebugMetaProps) {
{filteredImages.length ? (
<ScrollArea
ref={setScrollContainer}
style={{height: lockHeight ? MAX_HEIGHT : undefined, maxHeight: MAX_HEIGHT}}
style={{height: Math.min(totalSize, MAX_HEIGHT)}}
>
<div style={{height: totalSize, position: 'relative'}}>
{virtualizer.getVirtualItems().map(row => (
Expand All @@ -280,13 +267,7 @@ export function DebugMeta({data, projectSlug, groupId, event}: DebugMetaProps) {
</div>
</ScrollArea>
) : (
<Stack
align="center"
justify="center"
gap="md"
padding="lg"
style={lockHeight ? {height: MAX_HEIGHT} : undefined}
>
<Stack align="center" justify="center" gap="md" padding="lg">
<Text align="center" variant="muted">
{searchTerm
? t('No images match your search query')
Expand Down
Loading