Skip to content

feat(cmdk): Group project settings actions - #112913

Merged
JonasBa merged 4 commits into
masterfrom
jb/cmdk/project-settings-context
Apr 21, 2026
Merged

JonasBa merged 4 commits into
masterfrom
jb/cmdk/project-settings-context

Conversation

@JonasBa

@JonasBa JonasBa commented Apr 14, 2026 •

Copy link
Copy Markdown
Contributor

Add top current project settings specific CMDK entries that allow enable quick navigation between the different project settings pages for a given project. These will only be visible if the user is on one of the project settings pages.

CleanShot 2026-04-14 at 14 43 19@2x CleanShot 2026-04-14 at 14 43 14@2x

Refs GH-112564

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 14, 2026
@JonasBa
JonasBa force-pushed the jb/cmdk/project-settings-context branch from 4d528c9 to d4df676 Compare April 14, 2026 12:43
@sentry

sentry Bot commented Apr 14, 2026 •

Copy link
Copy Markdown
Contributor

Sentry Snapshot Testing

Name Added Removed Modified Renamed Unchanged Status
sentry-frontend
sentry-frontend
0 0 0 0 204 ✅ Unchanged

Group the project settings command palette entries under a single parent so browse mode stays more compact and easier to scan.

Add section-specific icons for the main project settings groups, keep legacy integrations as a direct action, and cover the new structure in the existing command palette test.

Co-Authored-By: OpenAI Codex <noreply@openai.com>
@JonasBa
JonasBa force-pushed the jb/cmdk/project-settings-context branch from 36fed98 to 0944e8c Compare April 14, 2026 13:04
@JonasBa
JonasBa marked this pull request as ready for review April 14, 2026 13:13
@JonasBa
JonasBa requested a review from a team as a code owner April 14, 2026 13:13
@JonasBa
JonasBa requested a review from rbro112 April 18, 2026 09:39
Comment thread static/app/views/settings/project/projectSettingsCommandPaletteActions.tsx Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a3a6c5b. Configure here.

The command palette grouping logic compared translated section names
(produced by t()) against hardcoded English strings. In any non-English
locale this caused all comparisons to fail, leaving the palette with a
flat, ungrouped list and no icons.

Replace all section.name / section.label comparisons with section.id
checks (e.g. 'settings-project', 'settings-sdk') which are locale-
independent. Also wrap display labels in t() for correctness.

Co-Authored-By: Claude <noreply@anthropic.com>
@JonasBa
JonasBa merged commit 165dc4a into master Apr 21, 2026
62 checks passed
@JonasBa
JonasBa deleted the jb/cmdk/project-settings-context branch April 21, 2026 22:17
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2026

This branch was successfully deployed

1 active deployment
Preview — f33d1674 Deployed Apr 21, 2026 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants