Skip to content

fix: https support spotlight transport - #3136

Open
sandstrom wants to merge 2 commits into
getsentry:masterfrom
sandstrom:copilot/fix-https-support-spotlight-transport
Open

sandstrom wants to merge 2 commits into
getsentry:masterfrom
sandstrom:copilot/fix-https-support-spotlight-transport

Conversation

@sandstrom

Copy link
Copy Markdown

Description

Add support for HTTPs in spotlight transport. Useful when running spotlight in docker container or behind proxy for example.

# this now works
config.spotlight = "https://spotlight.example:9443/stream"

Fixes: #3128

Copilot AI and others added 2 commits October 13, 2026 13:08
Co-authored-by: sandstrom <122287+sandstrom@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 707aed3. Configure here.

sidecar = URI(@sidecar_url)
connection = ::Net::HTTP.new(sidecar.hostname, sidecar.port, nil)
connection.use_ssl = false
connection.use_ssl = sidecar.scheme == "https"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTTPS skips transport SSL configuration

Medium Severity

conn enables SSL for https sidecar URLs but never applies ssl_configuration. ssl_verification, ssl_ca_file, and transport.ssl are ignored, so the connection keeps Net::HTTP's default peer verification and system trust store. Private CAs and disabled verification, typical for Docker or an intercepting proxy, fail for Spotlight while the main transport honors the same settings.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 707aed3. Configure here.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I see the security issue here:

Private CAs and disabled verification, typical for Docker or an intercepting proxy, fail for Spotlight while the main transport honors the same settings.

While this is true, it's not a security issue (on the contrary, disabling verification would be), and more of a feature limitation.

This change would only make vanilla HTTPS work, not special cases with Private CAs.

That said, if you as maintainers prefer another approach, let me know or feel free to amend this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support HTTPS in Spotlight transport

2 participants