Repository navigation
ci: Replace secrets: inherit with explicit CODECOV_TOKEN pass - #3047
Merged
oioki merged 1 commit intoAug 5, 2026
Conversation
The test job inherited all repository secrets to call gem_test.yml, which only reads secrets.CODECOV_TOKEN but never declared it under workflow_call.secrets. Declare it explicitly and pass only that secret by name instead of exposing every repository secret to the called workflow. Refs VULN-2296 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dingsdax
approved these changes
Aug 5, 2026
oioki
deleted the
alextarasov/vuln-2296-improper-authorization-vulnerability-in-getsentrysentry-ruby
branch
August 5, 2026 14:01
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testjob intests.ymlusedsecrets: inheritwhen callinggem_test.yml, exposing every repository secret to that workflow.gem_test.ymlonly readssecrets.CODECOV_TOKEN(to upload coverage) but never declared it underworkflow_call.secrets.gem_test.ymland updatedtests.ymlto pass only that secret by name.Test plan
gem_test.ymlonly referencessecrets.CODECOV_TOKENtestjob still uploads coverage correctly on this PRFixes VULN-2296
🤖 Generated with Claude Code