Skip to content

[devcontainer] fix git command in run script #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solnic merged 1 commit into from
Sep 22, 2025
Merged

[devcontainer] fix git command in run script #2710

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .devcontainer/run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ cd /workspace/sentry
sudo mkdir -p vendor/gems
sudo chown -R sentry:sentry vendor/gems

git config --global safe.directory /workspace/sentry
git config --global safe.directory /workspace/sentry/vendor/gems/*
git config --global --replace-all safe.directory /workspace/sentry
git config --global --replace-all safe.directory /workspace/sentry/vendor/gems/*

@cursor cursor Bot Sep 19, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Git Config Overwrites Safe Directories

The --replace-all flag on the second git config command causes it to overwrite the first safe.directory setting. This results in only /workspace/sentry/vendor/gems/* being configured as safe, while /workspace/sentry is unintentionally removed, which could lead to git operations failing.

Fix in Cursor Fix in Web


sudo chown -R sentry:sentry .

Expand Down
Loading