ci: reduce sample app build matrix to production-only - #6687
Conversation
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
19cb5a8 to
f0af8a5
Compare
| # support in 9.20.0, so the source-build fallback | ||
| # (`SENTRY_USE_XCFRAMEWORK=0`) can no longer resolve newer versions | ||
| # and is not exercised here. | ||
| build-type: ["production"] |
There was a problem hiding this comment.
Android dev (bare RN) — kept: it's the only guard for the #6398 ABI-filter regression (builds arm64-v8a only + runs check-tm-perf-logger-abi-subset.sh). No equivalent check in the production job.
What do you think of keeping this too?
Similar to the reasoning on keeping the Android dev build below we should keep one dev build for iOS too. As a dev tool we should guard that the sdk builds with metro in development and xcode debug config etc
There was a problem hiding this comment.
That said we can strip the dev mode in the recently added vision os and tvos and keep only the bare ios
antonis
left a comment
There was a problem hiding this comment.
Overall looks good. Left a comment to discuss further
Drop dev builds from iOS, macOS, visionOS, tvOS (bare RN) and all platforms (Expo). Android dev build is kept — it's the only guard for the #6398 ABI-filter regression (arm64-v8a subset + perf-logger check). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
f0af8a5 to
627dce5
Compare
antonis
left a comment
There was a problem hiding this comment.
LGTM
If you agree we can also remove tvos and visionos dev builds here or in a follow up PR
📢 Type of change
📜 Description
Removes dev builds from the sample app CI matrix where they provide no unique signal.
Not changed: bare RN iOS (has xcframework/cocoapods dimension) and bare RN Android (dev build is the only guard for the #6398 ABI-filter regression).
Trade-off: dev-mode regressions are no longer caught in CI — they'll surface locally when running the sample app in dev mode.
💡 Motivation and Context
Closes #5770.
💚 How did you test it?
Matrix change only — verified by diffing the workflow files. No logic changed.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps