ref: remove private helper usage from pydantic_ai tests - #7708
Open
Morningstar202604 wants to merge 1 commit into
Open
Morningstar202604 wants to merge 1 commit into
Morningstar202604 wants to merge 1 commit into
Conversation
Tests no longer call _set_input_messages directly. The standalone unit tests for the helper (error handling, list content, system prompt part, instructions, prompts disabled) were already covered by the agent-run tests and were removed. The two binary content tests now run through a real Agent while keeping the same span assertions.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed all direct calls to
_set_input_messagesfrom the pydantic_ai integration tests, following the review note on #5629. The tests now only exercise the public agent-run path.Five standalone tests that called the helper in isolation (error handling, list content, system prompt part, instructions, prompts disabled) were removed because the agent-run tests in the same file already cover those scenarios. The two binary content tests were the only ones asserting the actual blob payload inside the span, so I rewrote them to run through a real Agent while keeping the same assertions.
Issues
test_pydantic_aito remove usage of internal functions within tests #5637Verification
pytest tests/integrations/pydantic_ai/passes locally: 326 passedruff checkandruff format --checkclean