Skip to content

Drop events, breadcrumbs after faulty callbacks - #7707

Merged
sentrivana merged 3 commits into
major/3.0from
ivana/major/drop-callbacks
Sep 24, 2026
Merged

sentrivana merged 3 commits into
major/3.0from
ivana/major/drop-callbacks

Conversation

@sentrivana

@sentrivana sentrivana commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

If before_breadcrumb, an event processor, or an error processor raises an exception, the associated breadcrumb or event should be discarded as per spec.

Change goes into new major since it's breaking.

@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

62923 passed | ❌ 1 failed | ⏭️ 2890 skipped | Total: 65814 | Pass Rate: 95.61% | Execution Time: 170m 54s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -71240
Passed Tests 📉 -66979
Failed Tests 📈 +1
Skipped Tests 📉 -4262

➕ New Tests (1)

View new tests
  • test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 140508783394816

Stack Trace
tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:216: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 140508783394816

✅ Patch coverage is 100.00%. Project has 2075 uncovered lines.
❌ Project coverage is 90.12%. Comparing base (58ea973) to head (21121d1).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.20%    90.12%    -0.08%
==========================================
  Files          194       178       -16
  Lines        26030     21009     -5021
  Branches      9678      7584     -2094
==========================================
+ Hits         23480     18934     -4546
- Misses        2550      2075      -475
- Partials      1454      1197      -257

Generated by Codecov Action

@sentrivana
sentrivana marked this pull request as ready for review September 24, 2026 14:30
@sentrivana
sentrivana requested a review from a team as a code owner September 24, 2026 14:30
@sentrivana
sentrivana merged commit 6b4d3ec into major/3.0 Sep 24, 2026
145 of 147 checks passed
@sentrivana
sentrivana deleted the ivana/major/drop-callbacks branch September 24, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants