Skip to content

fix: Keep event if processor raises - #7701

Merged
sentrivana merged 2 commits into
masterfrom
ivana/dont-drop-on-processor-errors
Sep 24, 2026
Merged

sentrivana merged 2 commits into
masterfrom
ivana/dont-drop-on-processor-errors

Conversation

@sentrivana

@sentrivana sentrivana commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

As this is technically a breaking change and we have a major around the corner, let's do it there. Reverting this change on master.

Comment thread sentry_sdk/scope.py
@sentrivana
sentrivana marked this pull request as ready for review September 24, 2026 11:27
@sentrivana
sentrivana requested a review from a team as a code owner September 24, 2026 11:27
@github-actions

github-actions Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

129902 passed | ⏭️ 7152 skipped | Total: 137054 | Pass Rate: 94.78% | Execution Time: 428m 35s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +3061
Passed Tests 📈 +3063
Failed Tests 📉 -2
Skipped Tests

➖ Removed Tests (1)

View removed tests
  • test_binary_content_encoding_mixed_content[False-False]
    • File: tests.integrations.litellm.test_litellm

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2544 uncovered lines.
✅ Project coverage is 90.23%. Comparing base (a69ac4b) to head (0d90cbe).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
+ Coverage    90.22%    90.23%    +0.01%
==========================================
  Files          194       194         —
  Lines        25997     26030       +33
  Branches      9662      9678       +16
==========================================
+ Hits         23454     23486       +32
- Misses        2543      2544        +1
- Partials      1451      1455        +4

Generated by Codecov Action

@sentrivana
sentrivana merged commit b499d89 into master Sep 24, 2026
314 of 316 checks passed
@sentrivana
sentrivana deleted the ivana/dont-drop-on-processor-errors branch September 24, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants