Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
- Guard size arithmetic when parsing envelopes and Linux OS release data, copying slices, and allocating memory during crash handling. ([#2059](https://github.com/getsentry/sentry-native/pull/2059))
- macOS: prevent out-of-bounds reads while parsing Mach-O load commands. ([#2065](https://github.com/getsentry/sentry-native/pull/2065))
- Prevent out-of-bounds reads when parsing JSON numbers from length-delimited buffers. ([#2067](https://github.com/getsentry/sentry-native/pull/2067))
- Native/Windows: resolve the WER module relative to `handler_path`, so it is found when the crash handler is installed outside the executable's directory. ([#2073](https://github.com/getsentry/sentry-native/pull/2073))

**Thank you**:

Expand Down
39 changes: 32 additions & 7 deletions src/backends/sentry_backend_native.c
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,34 @@ wer_delete_registry_value(const sentry_path_t *wer_path)
}

static sentry_path_t *
wer_default_path(void)
wer_path_in_dir(const sentry_path_t *dir)
{
sentry_path_t *wer_path = sentry__path_join_str(dir, "sentry-wer.dll");
if (wer_path && sentry__path_is_file(wer_path)) {
return wer_path;
}
sentry__path_free(wer_path);
return NULL;
}

static sentry_path_t *
wer_module_path(const sentry_options_t *options)
{
if (options && options->handler_path) {
sentry_path_t *handler_path
= sentry__path_absolute(options->handler_path);
sentry_path_t *handler_dir = sentry__path_dir(
handler_path ? handler_path : options->handler_path);
sentry__path_free(handler_path);
if (handler_dir) {
sentry_path_t *wer_path = wer_path_in_dir(handler_dir);
sentry__path_free(handler_dir);
if (wer_path) {
return wer_path;
}
}
}

sentry_path_t *current_exe = sentry__path_current_exe();
if (!current_exe) {
return NULL;
Expand All @@ -108,7 +134,7 @@ wer_default_path(void)
return NULL;
}

sentry_path_t *wer_path = sentry__path_join_str(exe_dir, "sentry-wer.dll");
sentry_path_t *wer_path = wer_path_in_dir(exe_dir);
sentry__path_free(exe_dir);
return wer_path;
}
Expand All @@ -129,7 +155,7 @@ wer_unregister_module(void)
}

static bool
wer_register_module(uint64_t app_tid)
wer_register_module(uint64_t app_tid, const sentry_options_t *options)
{
windows_version_t win_ver;
if (!sentry__get_windows_version(&win_ver) || win_ver.build < 19041) {
Expand All @@ -138,10 +164,9 @@ wer_register_module(uint64_t app_tid)
return false;
}

sentry_path_t *wer_path = wer_default_path();
if (!wer_path || !sentry__path_is_file(wer_path)) {
sentry_path_t *wer_path = wer_module_path(options);
if (!wer_path) {
SENTRY_WARN("Native WER module not found");
sentry__path_free(wer_path);
return false;
}

Expand Down Expand Up @@ -869,7 +894,7 @@ native_backend_startup(
}

# if defined(SENTRY_PLATFORM_WINDOWS) && !defined(SENTRY_PLATFORM_XBOX)
state->ipc->shmem->platform.wer_enabled = wer_register_module(tid);
state->ipc->shmem->platform.wer_enabled = wer_register_module(tid, options);
# endif

sentry_handler_strategy_t strategy =
Expand Down
Loading