Skip to content

fix(json): Bound numeric token parsing - #2067

Merged
jpnurmi merged 4 commits into
masterfrom
jpnurmi/fix/bounded-json-numbers
Sep 4, 2026
Merged

fix(json): Bound numeric token parsing#2067
jpnurmi merged 4 commits into
masterfrom
jpnurmi/fix/bounded-json-numbers

Conversation

@jpnurmi

@jpnurmi jpnurmi commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Parse numbers from a terminated copy of the token so length-delimited JSON buffers are never read past their declared boundary.

Close: NATIVE-223

Parse numbers from a terminated copy of the token so length-delimited JSON
buffers are never read past their declared boundary.

Close: NATIVE-223
@linear-code

linear-code Bot commented Sep 4, 2026

Copy link
Copy Markdown

NATIVE-223

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2fa4099. Configure here.

Comment thread src/sentry_json.c
@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.30769% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.32%. Comparing base (9a275bd) to head (995ebcf).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2067      +/-   ##
==========================================
- Coverage   74.35%   74.32%   -0.04%     
==========================================
  Files         103      103              
  Lines       26677    26730      +53     
  Branches     4855     4868      +13     
==========================================
+ Hits        19836    19866      +30     
- Misses       5503     5519      +16     
- Partials     1338     1345       +7     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jpnurmi
jpnurmi merged commit fe7f471 into master Sep 4, 2026
71 checks passed
@jpnurmi
jpnurmi deleted the jpnurmi/fix/bounded-json-numbers branch September 4, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants