fix(json): Bound numeric token parsing - #2067
Merged
Merged
Conversation
Parse numbers from a terminated copy of the token so length-delimited JSON buffers are never read past their declared boundary. Close: NATIVE-223
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2fa4099. Configure here.
mujacica
approved these changes
Sep 4, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2067 +/- ##
==========================================
- Coverage 74.35% 74.32% -0.04%
==========================================
Files 103 103
Lines 26677 26730 +53
Branches 4855 4868 +13
==========================================
+ Hits 19836 19866 +30
- Misses 5503 5519 +16
- Partials 1338 1345 +7 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Parse numbers from a terminated copy of the token so length-delimited JSON buffers are never read past their declared boundary.
Close: NATIVE-223