fix(apple): Bound Mach-O load command parsing - #2065
Merged
Conversation
Keep each load command within sizeofcmds and validate command-specific sizes before reading segment or UUID data. This mirrors the bounds-checked load command walk used by the native crash daemon. Close: NATIVE-220
jpnurmi
force-pushed
the
jpnurmi/fix/macho-command-bounds
branch
from
September 4, 2026 12:12
dab6818 to
580c5ef
Compare
mujacica
approved these changes
Sep 4, 2026
JoshuaMoelans
approved these changes
Sep 4, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2065 +/- ##
==========================================
- Coverage 74.41% 74.32% -0.09%
==========================================
Files 103 103
Lines 26734 26742 +8
Branches 4868 4873 +5
==========================================
- Hits 19893 19877 -16
- Misses 5500 5513 +13
- Partials 1341 1352 +11 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep each load command within
sizeofcmdsand validate command-specific sizes before reading segment or UUID data. This mirrors the bounds-checked load command walk used in sentry_crash_daemon.c.Close: NATIVE-220