Repository navigation
Conversation
Pass onlyIfParent to the Supabase auth and PostgREST startSpanManual calls so a query made without an active span no longer becomes its own root span.
chiliec
requested review from
andreiborza,
isaacs,
logaretm and
msonnb
and removed request for
a team
October 28, 2026 11:03
chiliec
requested review from
chargome and
nicohrubec
and removed request for
a team
October 28, 2026 11:04
andreiborza
reviewed
Oct 28, 2026
andreiborza
reviewed
Oct 28, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25806
The
supabaseintegration creates db spans even when there is no active span, so each query becomes its own root span with no context.Fix
Pass
onlyIfParent: trueto bothstartSpanManualcalls inpackages/core/src/integrations/supabase.ts(the auth wrapper and the PostgREST query wrapper). A query made without an active parent span now creates no span — e.g. in the browser, queries after the pageload/navigation span has ended.Tests
Added an
onlyIfParentsuite topackages/core/test/lib/integrations/supabase.test.tsasserting both the PostgREST and auth paths passonlyIfParent: true.Validation
Node 24.22.1, pnpm 12.11.2.
RED (before the src change): the two new tests fail —
expected undefined to be true.GREEN (with the fix): full file passes.
npx oxlintandnpx oxfmt --checkon both files are clean. CHANGELOG updated under Unreleased.