Repository navigation
test(e2e): Fix optional Anthropic and OpenAI decisions apps - #25795
Merged
Merged
Conversation
Contributor
size-limit report 📦Compared: a637f06 (PR test merge using develop at 11c1245) Against: 11c1245 (develop) · base run #63940 ✅ Baseline matches: this diff contains only this PR's changes.
|
mydea
force-pushed
the
test/e2e-fix-optional-ai-apps
branch
from
October 28, 2026 11:18
8a3c86a to
95c534e
Compare
mydea
marked this pull request as ready for review
October 28, 2026 11:18
mydea
requested review from
andreiborza,
chargome,
isaacs,
logaretm,
msonnb and
nicohrubec
and removed request for
a team
October 28, 2026 11:18
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful, 3 successful. See the run.
Successful checks
|
andreiborza
approved these changes
Oct 28, 2026
nicohrubec
approved these changes
Oct 28, 2026
The Anthropic SDK 1.x targets API version 2026-10-21, which removed `temperature` from message params, so the latest variant no longer compiles. The OpenAI decisions test still expected the Vercel AI origin from before #25602. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The attribute is sent but not returned by the Sentry API for the span. Request params stay covered by node-integration-tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
force-pushed
the
test/e2e-fix-optional-ai-apps
branch
from
October 28, 2026 13:29
d375b67 to
7c1bebc
Compare
mydea
added a commit
that referenced
this pull request
Oct 28, 2026
…ment (#25819) **Why:** When the report job couldn't update the PR comment (e.g. a GitHub API `Server Error`), it logged a warning and passed, so the comment silently kept the results of an earlier attempt. This happened on #25795, where a re-run's results never made it into the comment. Failing the job makes a stale comment visible and lets you re-run just the report job. The job lives in the optional E2E workflow, so this doesn't block merges. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
51 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Two optional E2E apps fail on
develop, independent of any PR:node-anthropic-send-to-sentry (latest)doesn't compile:@anthropic-ai/sdk1.0 moved to API version2026-10-21, which removedtemperaturefrom message params. The app source is shared with the pinned 0.63.0 variant, so it dropstemperatureand the e2e no longer assertsgen_ai.request.temperature. Request params stay covered bynode-integration-tests.node-openai-decisions-send-to-sentry(both variants) still expected the Vercel AI originauto.vercelai.channelfrom before feat: Make span origins spec compliant #25602 renamed it toauto.ai.vercelai.Depends on: #25750. Our Anthropic instrumentation only matches SDK versions
<1, so the latest variant compiles with this PR but still produces no gen_ai spans until #25750 raises the range.🤖 Generated with Claude Code