Repository navigation
Conversation
logaretm
changed the title
Contributor
size-limit report 📦Compared: b686c95 (PR test merge using develop at 665318a) Against: a6c28d0 (develop) · base run #63865
|
logaretm
force-pushed
the
awad/tunnel-manual-wiring-tests
branch
from
October 27, 2026 22:28
04d9cdf to
907a37a
Compare
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 5 not successful, 60 successful. See the run.
Successful checks
|
logaretm
marked this pull request as ready for review
October 27, 2026 23:43
logaretm
requested review from
andreiborza and
isaacs
and removed request for
a team
October 27, 2026 23:43
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 907a37a. Configure here.
| } | ||
|
|
||
| return runner.getPort()!; | ||
| } |
There was a problem hiding this comment.
HTTP/2 test polls port with sleeps
Low Severity
waitForPort polls getPort() with setTimeout and then non-null-asserts the result. That was flagged because the review rules treat timeouts and sleeps in tests as a flake pattern and ask for a concrete readiness signal instead, the same way makeRequest already waits on the runner’s port-ready promise.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 907a37a. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tunnel helpers from #25783 had no coverage of wiring them by hand in real servers, fixed by adding integration and e2e suites for it.
The tests forward through node:http, HTTP/2, Express, Fastify and Koa (also run on Bun and Deno), Cloudflare in and outside
withSentry, and a Next.js Pages API route and middleware under basePath.