Skip to content

fix(opentelemetry): Normalize performance timestamps - #25744

Open
MathurAditya724 wants to merge 1 commit into
developfrom
codex/fix-otel-performance-timestamps
Open

MathurAditya724 wants to merge 1 commit into
developfrom
codex/fix-otel-performance-timestamps

Conversation

@MathurAditya724

Copy link
Copy Markdown
Member

OpenTelemetry spans started or ended with performance.now() now use Unix-epoch timestamps and preserve millisecond durations. Previously these numbers were interpreted as Sentry timestamps in seconds, causing Next.js client-component loading spans to appear near 1970 and inflating trace durations.

Normalize numeric time inputs for OpenTelemetry-created spans while retaining the direct Sentry API's seconds-based behavior. Idle-span cancellation passes an unambiguous high-resolution timestamp so it works with either kind of descendant span.

Fixes #25743

Preserve OpenTelemetry millisecond timestamps without changing direct Sentry span timing.

Fixes #25743

Co-Authored-By: GPT-6 <codex@openai.com>
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Compared: 2bb650c (PR test merge using develop at a734d03)

Against: a734d03 (develop) · base run #63565

✅ Baseline matches: this diff contains only this PR's changes.

Path Size % Change Change
@sentry/browser 29.98 kB - -
@sentry/browser - with treeshaking flags 28.13 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 28.03 kB - -
@sentry/browser (incl. Tracing) 52.25 kB +0.15% +74 B 🔺
@sentry/browser (incl. Tracing + Span Streaming) 52.26 kB +0.16% +80 B 🔺
@sentry/browser (incl. Tracing, Profiling) 55.17 kB +0.1% +54 B 🔺
@sentry/browser (incl. Tracing, Replay) 92.03 kB +0.06% +54 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 80.92 kB +0.08% +64 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 96.76 kB +0.06% +57 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 109.7 kB +0.06% +63 B 🔺
@sentry/browser (incl. Feedback) 47.51 kB - -
@sentry/browser (incl. sendFeedback) 35.05 kB - -
@sentry/browser (incl. FeedbackAsync) 40.15 kB - -
@sentry/browser (incl. Metrics) 31.01 kB - -
@sentry/browser (incl. Logs) 31.28 kB - -
@sentry/browser (incl. Metrics & Logs) 31.94 kB - -
@sentry/react 31.81 kB - -
@sentry/react (incl. Tracing) 54.57 kB +0.14% +72 B 🔺
@sentry/vue 38.26 kB +0.32% +119 B 🔺
@sentry/vue (incl. Tracing) 55.17 kB +0.12% +62 B 🔺
@sentry/svelte 30.01 kB - -
@sentry/remix (Remix 3 client bundle) 57.29 kB +0.17% +94 B 🔺
CDN Bundle 31.76 kB - -
CDN Bundle (incl. Tracing) 52.77 kB +0.13% +67 B 🔺
CDN Bundle (incl. Logs, Metrics) 33.95 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 54.74 kB +0.15% +80 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 74.93 kB - -
CDN Bundle (incl. Tracing, Replay) 90.48 kB +0.09% +73 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 92.39 kB +0.07% +63 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 96.61 kB +0.07% +58 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 98.56 kB +0.07% +64 B 🔺
CDN Bundle - uncompressed 93.51 kB - -
CDN Bundle (incl. Tracing) - uncompressed 156.56 kB +0.13% +194 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed 100.06 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 162.53 kB +0.12% +194 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 230.28 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 276.9 kB +0.08% +194 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 282.86 kB +0.07% +194 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 290.6 kB +0.07% +194 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 296.55 kB +0.07% +194 B 🔺
@sentry/nextjs (client) 57.45 kB +0.13% +73 B 🔺
@sentry/sveltekit (client) 52.61 kB +0.12% +60 B 🔺
@sentry/core/server 43.76 kB +0.32% +138 B 🔺
@sentry/core/browser 13.95 kB +1.05% +144 B 🔺
@sentry/node 153.9 kB +0.09% +128 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 81.58 kB - -
@sentry/node - without tracing 95.46 kB +0.16% +144 B 🔺
@sentry/node - without channel injection 134.57 kB +0.12% +148 B 🔺
@sentry/aws-serverless 103.59 kB +0.11% +111 B 🔺
@sentry/cloudflare (withSentry) - minified 195.91 kB +0.2% +389 B 🔺
@sentry/cloudflare (withSentry) 487.46 kB +0.23% +1.09 kB 🔺
@sentry/nextjs/cloudflare (withSentry) - minified 216.57 kB +0.18% +389 B 🔺

View base workflow run

@github-actions

Copy link
Copy Markdown
Contributor

Optional E2E tests

Some optional checks were not successful. They do not block the merge. 2 not successful, 63 successful. See the run.

Check Status
❌ CI: Optional E2E Tests / E2E node-anthropic-send-to-sentry (latest) Test (optional) Failing after 13s Details
❌ CI: Optional E2E Tests / E2E node-express-send-to-sentry-static Test (optional) Failing after 3m Details
Successful checks
Check Status
✅ CI: Optional E2E Tests / E2E astro-7 Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-flue (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E debug-id-sourcemaps Test (optional) Successful in 28s Details
✅ CI: Optional E2E Tests / E2E cloudflare-think Test (optional) Successful in 39s Details
✅ CI: Optional E2E Tests / E2E astro-7-static Test (optional) Successful in 45s Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (vinext, bun) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-openai-send-to-sentry Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps Test (optional) Successful in 22s Details
✅ CI: Optional E2E Tests / E2E nextjs-15 (turbo) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E cloudflare-agent Test (optional) Successful in 17s Details
✅ CI: Optional E2E Tests / E2E cloudflare-pi-durable (latest) Test (optional) Successful in 22s Details
✅ CI: Optional E2E Tests / E2E angular (canary) Test (optional) Successful in 53s Details
✅ CI: Optional E2E Tests / E2E deno (latest) Test (optional) Successful in 48s Details
✅ CI: Optional E2E Tests / E2E cloudflare-flue-send-to-sentry Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-mastra (latest) Test (optional) Successful in 40s Details
✅ CI: Optional E2E Tests / E2E supabase-nextjs Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-16-tunnel (cloudflare) Test (optional) Successful in 39s Details
✅ CI: Optional E2E Tests / E2E node-fastify-6 (tracer provider) Test (optional) Successful in 22s Details
✅ CI: Optional E2E Tests / E2E node-openai-decisions-send-to-sentry Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-anthropic-send-to-sentry Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-eve Test (optional) Successful in 34s Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (canary, webpack) Test (optional) Successful in 4m Details
✅ CI: Optional E2E Tests / E2E gen-ai-libraries (cloudflare) Test (optional) Successful in 22s Details
✅ CI: Optional E2E Tests / E2E node-mastra Test (optional) Successful in 41s Details
✅ CI: Optional E2E Tests / E2E nextjs-16-standalone (canary, turbopack) Test (optional) Successful in 20s Details
✅ CI: Optional E2E Tests / E2E nextjs-15 (latest) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (static / nuxt generate) Test (optional) Successful in 18s Details
✅ CI: Optional E2E Tests / E2E cloudflare-mastra Test (optional) Successful in 27s Details
✅ CI: Optional E2E Tests / E2E nuxt-5 Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-14 (canary) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E angular (canary) Test (optional) Successful in 50s Details
✅ CI: Optional E2E Tests / E2E nextjs-orpc Test (optional) Successful in 56s Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (canary, turbopack) Test (optional) Successful in 3m Details
✅ CI: Optional E2E Tests / E2E nextjs-14 (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nuxt-4-static (canary) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E solidstart-2 Test (optional) Successful in 38s Details
✅ CI: Optional E2E Tests / E2E cloudflare-pi-durable Test (optional) Successful in 22s Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (cloudflare, latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E react-router-7-framework-instrumentation Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E node-openai-send-to-sentry (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-openai-decisions-send-to-sentry (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E cloudflare-workers-send-to-sentry Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nuxt-4 (canary) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E node-eve (latest) Test (optional) Successful in 40s Details
✅ CI: Optional E2E Tests / E2E node-flue Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-fastify-6 Test (optional) Successful in 23s Details
✅ CI: Optional E2E Tests / E2E gen-ai-libraries Test (optional) Successful in 28s Details
✅ CI: Optional E2E Tests / E2E node-pi-durable Test (optional) Successful in 23s Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react-sourcemaps Test (optional) Successful in 21s Details
✅ CI: Optional E2E Tests / E2E node-pi-durable (latest) Test (optional) Successful in 22s Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react-cloudflare Test (optional) Successful in 18s Details
✅ CI: Optional E2E Tests / E2E node-express-send-to-sentry Test (optional) Successful in 56s Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (client source maps kept) Test (optional) Successful in 21s Details
✅ CI: Optional E2E Tests / E2E cloudflare-think (ai v6) Test (optional) Successful in 36s Details
✅ CI: Optional E2E Tests / E2E react-send-to-sentry Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E node-eve (orchestrion) Test (optional) Successful in 33s Details
✅ CI: Optional E2E Tests / E2E nuxt-3 (canary) Test (optional) Successful in 53s Details
✅ CI: Optional E2E Tests / E2E vue-3 (canary) Test (optional) Successful in 51s Details
✅ CI: Optional E2E Tests / E2E node-express-mcp-v1 Test (optional) Successful in 17s Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (vinext) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-express-mcp-v2 Test (optional) Successful in 16s Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (deno) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E vue-3 (no Options API) Test (optional) Successful in 52s Details

@MathurAditya724
MathurAditya724 marked this pull request as ready for review October 26, 2026 04:56
@MathurAditya724
MathurAditya724 requested a review from a team as a code owner October 26, 2026 04:56
@MathurAditya724
MathurAditya724 requested review from isaacs and mydea and removed request for a team October 26, 2026 04:56

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenTelemetry performance timestamps produce past-dated spans and inflated durations

1 participant