Repository navigation
feat(react-router): Serve the managed tunnel from a route in the server build - #25422
Merged
Merged
Conversation
Contributor
size-limit report 📦Compared: 957bffb (PR test merge using develop at 72b0363) Against: ca4fc32 (develop) · base run #62950
|
logaretm
force-pushed
the
awad/tunnel-react-router
branch
from
October 15, 2026 17:36
19cfdcb to
e1da135
Compare
logaretm
force-pushed
the
awad/tunnel-react-router
branch
from
October 15, 2026 17:44
e1da135 to
8bd81ed
Compare
logaretm
force-pushed
the
awad/tunnel-react-router
branch
2 times, most recently
from
October 15, 2026 18:26
1404a52 to
45ea3d1
Compare
logaretm
force-pushed
the
awad/tunnel-react-router
branch
from
October 15, 2026 18:28
45ea3d1 to
b227d1c
Compare
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
logaretm
force-pushed
the
awad/tunnel-react-router
branch
from
October 16, 2026 01:51
b227d1c to
808fd83
Compare
Member
Author
|
bugbot run |
logaretm
force-pushed
the
awad/tunnel-react-router
branch
from
October 16, 2026 02:25
808fd83 to
7d51d31
Compare
logaretm
force-pushed
the
awad/tunnel-react-router
branch
from
October 16, 2026 03:32
7d51d31 to
c8efd24
Compare
logaretm
force-pushed
the
awad/tunnel-react-router
branch
2 times, most recently
from
October 16, 2026 04:48
94ce573 to
3d0c6ae
Compare
logaretm
force-pushed
the
awad/tunnel-react-router
branch
from
October 16, 2026 14:00
3d0c6ae to
c5bc1f3
Compare
logaretm
force-pushed
the
awad/tunnel-react-router
branch
from
October 16, 2026 14:37
c5bc1f3 to
268adff
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 88b440e. Configure here.
logaretm
requested review from
JPeer264 and
Lms24
and removed request for
a team
October 19, 2026 20:08
logaretm
force-pushed
the
awad/tunnel-react-router
branch
from
October 19, 2026 20:08
88b440e to
c688a7c
Compare
Contributor
|
One or more gzipped bundles increased by more than 500 bytes. If this increase is intentional, add the Accept Bundlesize Increase label to this PR to rerun and accept the check. |
Contributor
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 6 not successful, 59 successful. See the run.
Successful checks
|
isaacs
approved these changes
Oct 26, 2026
isaacs
left a comment
isaacs
left a comment
Member
There was a problem hiding this comment.
On the right track. Left some comments.
…er build React Router has no request hook to answer from, so `sentryReactRouter()` adds a resource route whose path is read from the DSN at runtime. React Router reads it on its first request, so a request before `Sentry.init` keeps the tunnel off until restart.
The tunnel handler now answers a request without one with a 411.
…drop the variants the base path ones cover
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React Router has no request hook, so to wire the tunnel logic, we add a resource route to the server build whose path comes from the DSN at runtime.
The base path is the app's
basename, which the server build already exports. Thetunnel-basepathe2e variants cover dev, prod and Cloudflare.For reviewers: if you need an overview of what this is, refer to #25199.
closes #20255