Repository navigation
feat(tanstackstart-react): Serve the managed tunnel from the server entry - #25408
Merged
logaretm merged 23 commits intoOct 27, 2026
Merged
Conversation
Contributor
size-limit report 📦Compared: 287ad6a (PR test merge using develop at f9f8adc) Against: ca4fc32 (develop) · base run #62950
|
logaretm
force-pushed
the
awad/tunnel-tanstackstart
branch
from
October 15, 2026 15:36
2202cda to
46e486c
Compare
logaretm
force-pushed
the
awad/tunnel-tanstackstart
branch
3 times, most recently
from
October 15, 2026 17:15
9069686 to
b589186
Compare
logaretm
force-pushed
the
awad/tunnel-tanstackstart
branch
3 times, most recently
from
October 15, 2026 18:16
a5fcc1b to
f2a6beb
Compare
logaretm
force-pushed
the
awad/tunnel-tanstackstart
branch
2 times, most recently
from
October 15, 2026 18:28
722f4c6 to
eec9ddf
Compare
Member
Author
|
bugbot run |
logaretm
force-pushed
the
awad/tunnel-tanstackstart
branch
from
October 16, 2026 01:51
eec9ddf to
8d3dee9
Compare
Member
Author
|
bugbot run |
1 similar comment
Member
Author
|
bugbot run |
logaretm
force-pushed
the
awad/tunnel-tanstackstart
branch
from
October 16, 2026 02:25
8d3dee9 to
8c6c1fa
Compare
logaretm
force-pushed
the
awad/tunnel-tanstackstart
branch
2 times, most recently
from
October 16, 2026 14:00
6b24a7b to
64c909f
Compare
Contributor
|
One or more gzipped bundles increased by more than 500 bytes. If this increase is intentional, add the Accept Bundlesize Increase label to this PR to rerun and accept the check. |
Contributor
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 7 not successful, 58 successful. See the run.
Successful checks
|
isaacs
approved these changes
Oct 26, 2026
isaacs
left a comment
isaacs
left a comment
Member
There was a problem hiding this comment.
Some modest suggestions, but this overall is good. Replacing build-time route injection with a runtime matcher in front of the server entry is a nice improvement. Several of the comments below can be addressed by updating the PR description and changelog entry.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 32e2e21. Configure here.
…ntry
The Vite plugin now wraps the app's server entry, so `Sentry.init({ tunnel: true })`
works with no build option and tunnel requests are answered before Start's
request middleware and routing. Every `tunnelRoute` form is served the same way:
`true` uses the DSN-derived path instead of a random one per build, and a static
path no longer patches the generated route tree.
…th Start routes on
…nel's server entry wrapper
…lides with an app route, as on develop
…and serve it from there
…ith setManagedTunnelDefaults
…equests The tunnel handler now answers a request without one with a 411.
…ants, which other variants already cover
…the client tests that repeat core's
…lRoute`, and use a static `tunnelRoute` as written
…the default server entry The default entry lives in `@tanstack/react-start`, which does not depend on the SDK, so the bare import failed when the SDK is not hoisted to where it can see it, like with pnpm's global virtual store or Yarn PnP.
…ping it for the tunnel
…c `tunnelRoute` with a 405 Without it, Start renders the app for them and runs its root loaders, which #24615 fixed for the route based tunnel.
…unnel path, the DSN-derived one included
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TanStack Start picked a random tunnel path per build and patched the generated route tree to serve it.
Because the new approach relies less on build-time, the logic was changed to wrap the server entrypoint instead and only route the matching tunnel requests to our handler. The tradeoff is that every app using
sentryTanstackStart()gets its server entry wrapped, tunnel or not, sinceserveTunnelIntegration()turns the tunnel on at runtime. The original entry then loads through a?sentry-tunnel-originalid, and without a tunnel each request only pays one lookup.This isn't a breaking change, previously we injected a single endpoint handler, now we inject a middleware since the DSN is only known at runtime.
The base path comes from
router.basepath(or Vite'sbase), and thetunnel-basepathe2e variants cover it in both dev and prod.For reviewers: if you need an overview of what this is, refer to #25199.
closes #25461